Giter VIP home page Giter VIP logo

Comments (4)

benschwarz avatar benschwarz commented on May 23, 2024 4

I am generally not a fan of removing the ability to identify LH traffic. It is important to able to identify Lighthouse traffic in monitoring and firewall contexts.

As we know, cheating Lighthouse doesn't improve Core web vitals for visitors.

Yes, there are bad actors selling webperf plugins that intentionally mislead site owners.

My take: Abuse reports should be delivered to the platforms who host problematic plugins. Services like Wordpress and Shopify must maintain quality within their own marketplace.

Identification of traffic is important to software teams, agencies, consultants and all the folks who are focused on making positive webperf outcomes.

from lighthouse.

connorjclark avatar connorjclark commented on May 23, 2024

I will take care of making our client hints not signal Lighthouse, and changing the PSI UA header.

from lighthouse.

connorjclark avatar connorjclark commented on May 23, 2024

Next Lighthouse release will address the brand client hint, and next PSI release (~a day) will address its UA.

Checking for the Linux x86_64 value of navigator.platform.

I'm not convinced we should do this for purposes of evading detection. This is the same value that an actual Linux user would have. Are you seeing this used to detect Lighthouse? It'd be a pretty big false signal..

but, maybe worth doing to match the fake UA we set for mobile/desktop. @paulirish wdyt

from lighthouse.

krzksz avatar krzksz commented on May 23, 2024

Checking for the Linux x86_64 value of navigator.platform.

I'm not convinced we should do this for purposes of evading detection. This is the same value that an actual Linux user would have. Are you seeing this used to detect Lighthouse? It'd be a pretty big false signal..

but, maybe worth doing to match the fake UA we set for mobile/desktop. @paulirish wdyt

I figured it may be more appropriate for DevTools to handle it as a part of the device emulation. I created a bug against Chromium: https://issues.chromium.org/issues/326791407

@benschwarz In principle I agree with your statement. This is yet another case of "this is why we can't have nice things". We spent months to uncover as many cases as possible and I believe there are still more that we didn't identify. In reality, most platforms don't have enough resources to address this at all.

At the same time, there are real non-technical people paying $ to "performance experts" taking advantage of this.

from lighthouse.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.