Comments (2)
I believe we landed on this because it avoided landing a non-reversible change to the gatherer implementation that affects filtering, which is already kinda complex. But this doesn't help for custom gatherers.
We also have --disable-full-page-screenshot
to exclude this logic for the FPS audit ... so a gatherer option called alwaysRun: true
would be more like alwaysRunUnlessToldOtherwise
:p Maybe runOnlyWhenRequested
or runOnlyIfNeeded: false
or supplementary: true
...
Is it an option for you to always include (via --only-audits
) a hidden audit that depends on your custom artifact?
from lighthouse.
Yeah that's a valid point, adding such new property might end up making things even more complex.
In regards to the hidden audit, yes, that's what I tried when I found out that gatherers are filtered.
At first, I didn't get why it was not working, then I realised I needed to include the gatherer in an audit. So I implemented a fake audit, like the one in the example below, but I felt like it was not the best way to do it and I was wondering whether could be feasible to, in a way, decouple gatherers from audits.
class MyAudit extends Audit {
static get meta() {
return {
id: 'my-audit',
title: 'My Audit',
failureTitle: 'Dummy failure title',
description: 'Dummy description',
requiredArtifacts: ['MyGatherer'],
};
}
static audit() {
return {
score: 1
};
}
}
Thanks for your feedback, happy to discuss this further but feel free to close the issue.
from lighthouse.
Related Issues (20)
- https://github.com/GoogleChrome/lighthouse/issues/15877#issue-2200794339
- `ci.yml` uses a `deprecated` version of `Node.js` HOT 1
- all React sites are giving error that Your Docusaurus site did not load properly. HOT 3
- why not all relevant audits are part of response ?. HOT 1
- High LCP due to text element.
- https://github.com/GoogleChrome/related-website-sets/issues/458#issue-2390012009
- https://github.com/GoogleChrome/related-website-sets/issues/458#issue-2390012009
- Roddyp HOT 1
- Having source maps in production is not a best practice. Then why the error?
- [Spam]
- pwa lighthouse HOT 1
- Discrepancy between reported total and sum of resource transfer sizes in audits.resource-summary HOT 2
- Add default gatherer replacement doc example HOT 3
- Run Lighthouse on iOS physical device (iPhone) HOT 1
- High memory consumption from trace engine HOT 2
- Not able to collect Performance score get (!) , as suggested by Lighthouse next tried in Incognito mode, still no score generated. HOT 2
- Inconsistent Media Resource Count Between resource-summary and network-requests Audits HOT 1
- Unexpected Cookie/opensearch.xml error in console HOT 2
- Discrepancy between LCP measurement and actual element render HOT 4
- Page loads very slowly due to CSS.enable HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lighthouse.