Giter VIP home page Giter VIP logo

Comments (7)

FluorescentHallucinogen avatar FluorescentHallucinogen commented on June 5, 2024 1

What if the user knows that PWA fails the quality criteria, but still need to pack it in TWA (e.g. for tests)?

I believe tools should just do their job, not create problems for users.

from bubblewrap.

FluorescentHallucinogen avatar FluorescentHallucinogen commented on June 5, 2024

If the PWA fails the quality criteria, fail the build step

Looks like not a good idea. IMO, warning is fine.

from bubblewrap.

FluorescentHallucinogen avatar FluorescentHallucinogen commented on June 5, 2024

Or it should be configurable.

from bubblewrap.

andreban avatar andreban commented on June 5, 2024

from bubblewrap.

andreban avatar andreban commented on June 5, 2024

I believe tools should just do their job, not create problems for users.

The quality criteria is a requirement when creating a Trusted Web Activity, so the tool is not creating a problem, but ensuring developers detect it earlier. The quality criteria is not currently being enforced elsewhere, but we expect this to change.

I agree we should provide a way for developers to test their application. We can add a flag to skip the checks when building the application.

from bubblewrap.

FluorescentHallucinogen avatar FluorescentHallucinogen commented on June 5, 2024

+1 for adding a flag to skip the checks.

from bubblewrap.

andreban avatar andreban commented on June 5, 2024

This was closed via #134

from bubblewrap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.