Comments (7)
What if the user knows that PWA fails the quality criteria, but still need to pack it in TWA (e.g. for tests)?
I believe tools should just do their job, not create problems for users.
from bubblewrap.
If the PWA fails the quality criteria, fail the build step
Looks like not a good idea. IMO, warning is fine.
from bubblewrap.
Or it should be configurable.
from bubblewrap.
from bubblewrap.
I believe tools should just do their job, not create problems for users.
The quality criteria is a requirement when creating a Trusted Web Activity, so the tool is not creating a problem, but ensuring developers detect it earlier. The quality criteria is not currently being enforced elsewhere, but we expect this to change.
I agree we should provide a way for developers to test their application. We can add a flag to skip the checks when building the application.
from bubblewrap.
+1 for adding a flag to skip the checks.
from bubblewrap.
This was closed via #134
from bubblewrap.
Related Issues (20)
- Build: java.lang.OutOfMemoryError HOT 7
- Providing "--apkFile" doesn't work
- Add Suffix to User-Agent or Referrer with the version of the TWA HOT 1
- App must target Android 13 (API level 33) or higher HOT 1
- Failed verification assetlinks
- [Help] How to download the build tools only once using docker?
- dont show browser address bar after install HOT 3
- Base Plans are not supported in bubblewrap twa subscriptions
- PWA shortcuts not showing up HOT 1
- Enforce https manifest URL HOT 1
- Issue in bubblewrap build command HOT 3
- DelegationService not starting HOT 3
- Failed to load signer "signer #1" - java.io.IOException: Integrity check failed: java.security.NoSuchAlgorithmException HOT 2
- Should touchscreen user-feature be non-required in manifest
- Disable Screen Rotation
- PWA: Call to Javascript "alert()" causes un-dismissible URL bar to appear
- CLI ERROR ON BUILD HOT 2
- Play Store: "This SDK version has been reported as outdated." HOT 1
- cli ERROR unrecognised content at end of stream HOT 1
- Unable to use Bubblewrap Build
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bubblewrap.