Comments (5)
That's a left-over from svgomg-twa, which was used as a base for the template. We can reset that back to 1.0.0
.
Nevertheless, we need a mechanism to enable #3, where versionCode
and versionName
are updated with the template.
One option is to control this via the template. We'd have to bump versionName
and versionCode
on the template when it's changed, and update
would apply the new template.
The second option (somewhat my preferred, is to save the current versionCode and versionName to twa-manifest.json
and bump it when llama-pack update
is invoked. We'd still probably want to have a way to track template versions, for debugging purposes.
from bubblewrap.
versionCode
is the bit that really matters on the Play Store, and the number must always go up between versions. I think we can just have the 2 values on the twa-manifest and update them independently. eg:
...
"version": {
"code": 1,
"name": "1.0.0"
}
...
from bubblewrap.
Moving the conversation on how to update versions to #74 and closing this issue, as resetting the versionName
has been implemented on #71.
from bubblewrap.
Reading about Versioning Android apps here...
What do you think of having a version
field in the manifest?
And let the build.gradle
generate versionCode
and versionName
.
Something like:
...
"version": "2.3.1",
...
And then the build.gradle
generates:
versionCode 20301
versionName "2.3.1"
(ignoring the API level and screen sizes from the post)
Then the user just need to update the application version in the manifest in a semantic version way.
To calculate the versionCode
:
const versionCode = (majorVersion * 10000) + (minorVersion * 100) + patchVersion;
from bubblewrap.
Yes, but following a formula like this, the versionCode
would always increase:
const versionCode = (majorVersion * 10000) + (minorVersion * 100) + patchVersion;
So a version like "2.3.1"
generates the version code 20301
.
But having both options also works. 👍
from bubblewrap.
Related Issues (20)
- :)
- Build: java.lang.OutOfMemoryError HOT 7
- Providing "--apkFile" doesn't work
- Add Suffix to User-Agent or Referrer with the version of the TWA HOT 1
- App must target Android 13 (API level 33) or higher HOT 1
- Failed verification assetlinks
- [Help] How to download the build tools only once using docker?
- dont show browser address bar after install HOT 3
- Base Plans are not supported in bubblewrap twa subscriptions
- PWA shortcuts not showing up HOT 1
- Enforce https manifest URL HOT 1
- Issue in bubblewrap build command HOT 3
- DelegationService not starting HOT 3
- Failed to load signer "signer #1" - java.io.IOException: Integrity check failed: java.security.NoSuchAlgorithmException HOT 1
- Should touchscreen user-feature be non-required in manifest
- Disable Screen Rotation
- PWA: Call to Javascript "alert()" causes un-dismissible URL bar to appear
- CLI ERROR ON BUILD HOT 2
- Play Store: "This SDK version has been reported as outdated." HOT 1
- cli ERROR unrecognised content at end of stream HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bubblewrap.