Comments (5)
tomayac
commented on May 20, 2024
Thanks for opening the issue. The problem you're describing was already discussed before, I have provided an answer in #20 (comment). Hope this helps. I'm closing the issue, but feel free to comment again. Cheers!
from dark-mode-toggle.
francislavoie
commented on May 20, 2024
Ah thanks, I searched for the wrong words 👍
You said:
So long story short, there’s no way to prevent this, but you can limit the negative effect by making sure the toggle code executes as soon as possible during the loading phase of your page. Hope this helps somewhat.
It seems to me like the toggle code doesn't run until <dark-mode-toggle> is encountered (I'm making this assumption because if the JS is in the <head> but the toggle element is not rendered, nothing happens). I put <script type="module" src="https://unpkg.com/dark-mode-toggle"></script> as early as possible in the <head> but it still happens. Is there anything else I could do to make it load earlier?
from dark-mode-toggle.
tomayac
commented on May 20, 2024
You could preload the module:
<link rel="modulepreload" src="https://unpkg.com/dark-mode-toggle" crossorigin>from dark-mode-toggle.
francislavoie
commented on May 20, 2024
Hmm, looks like that's still experimental https://caniuse.com/#feat=link-rel-modulepreload
from dark-mode-toggle.
tomayac
commented on May 20, 2024
It is experimental. But where it works, it helps. And where it doesn't work, it doesn't cause harm.
from dark-mode-toggle.
Related Issues (20)
- [Feature Request] Set SVG icons HOT 1
- Unable to Load png files when running on Github Pages HOT 2
- Apart from `light` and `dark`, add a `system` option HOT 9
- Add aria-label for lighthouse HOT 5
- Dead GitHub Pages HOT 1
- Any way to toggle light/dark native widgets when using <meta name='color-scheme' content='light dark'> ? HOT 3
- dark-mode-toggle with React HOT 10
- Dark mode website HOT 5
- "Permanent" property seems to have stopped working HOT 5
- Implement saving light/dark mode HOT 8
- Dark mode doesn't work HOT 5
- Keep light mode after changing page for Wordpress Theme HOT 3
- Accessibility error HOT 2
- Consider aria-label="auto" aria-live="polite" HOT 1
- Reloading in the demo in dark mode still causes an initial flash of the light theme. HOT 8
- Problems styling ::parts and pseudo elements such as ::before HOT 15
- [feature request] support SRI (sub resources integrity) HOT 6
- [feature request] support Bootstrap 5.3 color modes HOT 3
- Support for using as a React component HOT 2
- Add support for declarative shadow DOM
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dark-mode-toggle.