Comments (3)
This is indeed a strange outcome, but this is also strange code. I am not sure what the right thing here is.
Why do you have code filling the outputs above the status check? What do you expect the caller to see in that case?
from appengine-pipelines.
@tkaitchuck - The whole scenario is more complex then you see here. We autogenerate pipeline DAG in the code (we call them workflows), so in general there is more than one pipeline (the single-pipeline workflow example, I've posted above, is a special case). When one of the pipeline in a DAG fails, it's actually a critical situation for the whole workflow and all pipelines in the DAG should be aborted (that's why we raise Abort there). Later on, when we display the whole DAG status in our UI (using output generated by get_status_tree()), we would like to show user particular pipeline that has failed - we cannot depend on built-in pipeline status as all pipelines in the DAG have 'aborted' state in case of Abort exception being raised. That's why all our pipelines has "status" slot.
It looks like problem is in this line: https://github.com/GoogleCloudPlatform/appengine-pipelines/blob/master/python/src/pipeline/pipeline.py#L3178
The slots are added to the status tree only for the "child" pipelines, i.e. slot is not added for root pipeline. Is there a reason for it?
I'd like to open a pull request for this issue, but I'm having problems with running unit tests. Is there some README how to run them?
from appengine-pipelines.
I added a shell script to make it easier.
d6078c7
Run that with the argument 'test' and set the environment variable to point to your SDK.
from appengine-pipelines.
Related Issues (20)
- [Python][Bug] Yielded pipeline does not run on the specified task queue. HOT 3
- Files API Still Being Used in the demo app HOT 2
- In notify_barriers when queue task_retry_limit exceeded the pipeline never finalize HOT 5
- TaskQueue behavior for duplicate tasks in a list during Queue.add() HOT 3
- App Engine Pipeline not aborting all the way to root HOT 3
- Move pipeline URL from '/_ah/pipeline' to something else HOT 1
- ModulesService#getVersionHostname causes pipelines to fail often HOT 1
- Bumb pypi version? HOT 5
- Target param ignored during retry attempts and barrier notifications. HOT 4
- waitFor doesn't support FutureList HOT 2
- [JAVA] Cannot find the slot: pipeline-slot("56da1731-d616-4c7c-98e3-d21fe9e386b0"). Ignoring the task.
- GAE/GCE "python" runtime support? HOT 1
- exception during /_ah/pipeline/output: ancestor argument should match namespace ("'101970'" != "'102550'") HOT 1
- Sources for 0.2.13
- Use of im_func.
- Starting a task on a local module without an explicit version fails HOT 2
- cloud sdk 123 causes PipelineSetupError in dev server HOT 4
- _fix_path prevents module from importing if PYTHONPATH is not set
- Java: configure PipelineServlet to use a different (datastore) namespace
- Python: Bad target when running in development environments
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from appengine-pipelines.