error-reporting: fix up sample about golang-samples HOT 5 CLOSED

At @broady you mean this

IMHO it suffices and doesn't need removing to use panic, because it shows the user how to capture the stacktrace for their bug report. What do you think?

from golang-samples.

Yep, that one.

I guess it's fine, but I don't fully understand the usage of error reporting for Go. Do we really want people to only use it for panics?

/cc @rakyll

from golang-samples.

There's a package that may simplify the code a little; github.com/pkg/errors
Thus

import (
    "github.com/pkg/errors"
)
... 
// Handler for the incoming requests. 
func demoHandler(w http.ResponseWriter, r *http.Request) { 
 	err := errors.Error("Runtime Issue with demoHandler")
        if err != nil {
            report(err, r)
        }
}
func report(err Error, r *http.Request) {
        ...
        "stacktrace": errors.Errorf("%+v", err)
        ...
}

I'm not sure, though, how helpful stack traces are as Rob Pike has written that errors should be given context before before bubbled up the stack or dealt with without causing the system to fall over. Using the errors pkg we could now wrap one error context within another potentially creating a much nicer and helpful error message rather than a stack trace (remembers screens full of java stack traces....!) Just my two pennies.

from golang-samples.

@broady @odeke-em I haven't seen any feedback about this. Do you still have ideas about how to improve it, or should we close this?

@Brotherhod Thanks for the link and example. I'd prefer to avoid using any additional external dependencies.

from golang-samples.

Declaring issue bankruptcy on this. Feel free to reopen if you want to fix it.

from golang-samples.