Giter VIP home page Giter VIP logo

Comments (7)

bourgeoisor avatar bourgeoisor commented on June 11, 2024

@theemadnes what do you think?

from kubernetes-engine-samples.

theemadnes avatar theemadnes commented on June 11, 2024

@bourgeoisor forgot about this one - just noticed when i put in the pr for resource requests. will do this next.

from kubernetes-engine-samples.

theemadnes avatar theemadnes commented on June 11, 2024

@gbrayut my thinking was to use your idea of a HOST envvar, populated by a configmap that defaults to 0.0.0.0 (and also the app will default to 0.0.0.0 if the envvar doesn't exist), because :: would pin logs to ipv6 format which is a tiny bit noisier. cool?

from kubernetes-engine-samples.

gbrayut avatar gbrayut commented on June 11, 2024

configmap sounds like extra work (vs just hard coding a default if HOST variable is not set), but I'm fine either way. And agree 0.0.0.0 as the default currently makes sense as long as there is an easy way to override.

from kubernetes-engine-samples.

theemadnes avatar theemadnes commented on June 11, 2024

#1071

from kubernetes-engine-samples.

theemadnes avatar theemadnes commented on June 11, 2024

tricky bit was, when testing, Flask and gRPC have different preferred formats for local all-interfaces IP (:: vs [::]).

from kubernetes-engine-samples.

theemadnes avatar theemadnes commented on June 11, 2024

i did end up extending the ConfigMap to include a HOST env var, but the app will set 0.0.0.0 as the default if the configmap doesn't provide it. also bumped version to .22.

from kubernetes-engine-samples.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.