Implement HEALTHCHECK command about kaniko HOT 5 CLOSED

Healthcheck requires a different config struct:
https://github.com/moby/moby/blob/master/api/types/container/config.go

It seems to be not included in the open container specs - thus implementing this would require completely replacing the base for configs.

After that - if I get the code right - it would simply mean passing the already prepared HealthConfig struct to the config to persist it. Which shouldn't be hard at all - but that requires HealthCheck to be existent in the container config.

Ideas?

from kaniko.

@dlorenc @priyawadhwa any idea?

from kaniko.

Hey, sorry for the late response! We use the go-containerregistry library for working with our images, and right now the config doesn't have a field for Healthcheck. You'd probably have to create the healthcheck config struct in go-containerregistry and add it to the config before starting to implement this command in kaniko.

from kaniko.

So you suggest contributing to go-containerregistry and using the merged version for proceeding here, correct?

from kaniko.

@chrisz100 correct! I can help you get that PR merged into go-containerregistry as well :)

from kaniko.