Comments (2)
When I set --kaniko-dir=foo
, during kaniko execution, it still used the config.KanikoDir
to get the environment variables(KANIKO_DIR
), hance the problem in this issue.
// pkg/executor/build.go:807
dstDir := filepath.Join(config.KanikoDir, strconv.Itoa(index))
When add the --kaniko-dir
parameter with corba, the default value is constants.DefaultKanikoPath
. I think can remove config.KanikoDir
and use the opts.KanikoDir
instead.
Because the Kaniko_DIR
environment variable and the --kaniko-dir
parameter tend to be confusing, don't you think?
// cmd/executor/cmd/root.go:243
RootCmd.PersistentFlags().StringVarP(&opts.KanikoDir, "kaniko-dir", "", constants.DefaultKanikoPath, "Path to the kaniko directory, this takes precedence over the KANIKO_DIR environment variable.")
from kaniko.
when doing copy and snapshooting we called config.KanikoDir
which read from envar default from package config
and we are not passing opts.KanikoDir to executeCommand so kaniko options is actually not passing to every command
if err := command.ExecuteCommand(&s.cf.Config, s.args); err != nil {
return errors.Wrap(err, "failed to execute command")
}
there is no kaniko-dir passsed
fixing all possibilities and pass the opts to every command in executeCommand method will be confusing and make a lot of changes so instead of passing forcing env KANIKO_DIR to values in --kaniko-dir would be better faster and more clear that KANIKO_DIR will be replaced once there is --kaniko-dir flag
with this you no need to specify both of them again to make it work
from kaniko.
Related Issues (20)
- Even when `KANIKO_NO_PUSH="true"` there is a info message with "Pushed"
- Creating a custom kaniko image using a multi-stage Dockerfile fails
- Generated image is missing files generated via RUN HOT 2
- [TEST FLAKE] Intermittently seeing - `No such image: localhost:5000/<test-image>` HOT 3
- [Bug] --registry-mirror does not work with warmer since v1.21.0 HOT 1
- error removing bin to make way for new symlink: unlinkat //bin/sh: permission denied
- Question regarding a vulnerability (CVE-2023-45288), vuln scans & results publishing HOT 2
- Setting `--kaniko-dir` (or `KANIKO_DIR`) clobbers `DOCKER_CONFIG` if it is explicitly set. HOT 2
- Execution takes too long for "Unpacking rootfs as cmd COPY" HOT 1
- "GET https://example.com/users/sign_in: unexpected status code 200 OK" when pushing to self-hosted GitLab with Kaniko HOT 5
- compression=zstd not working starting from v1.16
- After run kaniko in container, image is changed and part of local context stop to work HOT 2
- using Kaniko with a registry-mirror or registry-map which includes a path does not work for pulling images from DockerHub HOT 1
- Cannot pass empty value of --build-arg
- error pushing image: MANIFEST_BLOB_UNKNOWN: blob unknown to registry;
- Feature request: support --parents flag for COPY
- COPY --chmod=444 produces wrong directory permissions in v1.23.0 HOT 2
- Use Azure Default Credential to avoid using keys
- Kaniko doesn't support symlinks in Dockerfile HOT 1
- dockfile uses WORKDIR /workspace. An error must occur if cache is enabled. Why? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kaniko.