Counters: Default capacity should be 0 (max), not 1000 about agones HOT 5 CLOSED

/cc @igooch

from agones.

Defaulting is in the CRD:

from agones.

The number 0 is meaningful for Capacity (there's more places in fleetautoscaler, gameserverallocation, etc.):

It's only the MaxAvailable where 0 = max(int64):

We can set the default to 9223372036854775807, but I don't think we want to make 0 equal MaxInt64 because setting the Capacity to 0 is easiest way for the user to "delete" the Counter since they can't actually delete it.

from agones.

The number 0 is meaningful for Capacity (there's more places in fleetautoscaler, gameserverallocation, etc.):

aaah yeah, I can 100% see how that makes things way more complicated in the code. I agree, moving it to max(int64) is a better solution 👍🏻

Also making a note we should document this as well, as I think we don't document defaults for counter capacity, but we do for Counters.

@igooch you want to take this, or @Kalaiselvi84 this could be good for you? it's mostly a change in the default specified in #3579 (comment) and then updating the docs around counter default values in the example yamls and gameserver.md reference (I think that's the only spots).

from agones.

I will take on this work..

from agones.