Giter VIP home page Giter VIP logo

Comments (10)

justAsascha avatar justAsascha commented on June 12, 2024 9

Same error on node v20 and osx

from google-maps-services-js.

ArturAmpilogov avatar ArturAmpilogov commented on June 12, 2024 7

Another solution is to add the following code to the package.json:

"overrides": {
    "@googlemaps/url-signature": "1.0.32"
}

from google-maps-services-js.

abdirahmn1 avatar abdirahmn1 commented on June 12, 2024 5

Same error on node v20 and osx

Found a solution?

You can simply npm install --save [email protected] to get rid of the problem temporarily

from google-maps-services-js.

TimJohns avatar TimJohns commented on June 12, 2024 5

"Technically" this is a dupe of #1182, which was closed, but I'd recommend keeping this one open until the upstream releases are fixed, so that it's easier for folks to find this, and not open additional new issues.

In any case, despite the fact that google-maps-services-js is featured prominently in the call stack, 1.0.33 release requires core-js but states no dependency #528 is a little closer to the root cause, and might be a good place for additional upvotes and commentary.

In terms of @justAsascha's recommendation to make a contribution since it's Open Source, I took a full day to take a crack at it, and if I tracked it down correctly, I believe the issue is that in js-url-signature, babel is determining that core-js is required for a couple of polyfills (including es.string.replace) for older browser support. I removed core-js from the .babelrc and it all worked great FOR ME (Nodejs 20 environment), but that's pretty clearly a build config/release business decision more than a code fix. In my own personal opinion, completely removing the core-js dependency is slightly preferable, since older browsers could still use older versions explicitly, and the rest of us would have one less dependency, but that's definitely a business decision.

I conjecture someone could alternately move core-js from devDependencies to dependencies in the package.json for js-url-signature; but I didn't try that. If anyone does, tag me in the PR and I'm happy to pull it down and test here, comment, etc. Or if I run out of stuff to do and can spare another day (ha!) I'll take another crack at it.

Based on 1.0.33 release requires core-js but states no dependency #528, it sounds like folks are aware of it, but not sure who owns that decision. I recommend upvoting there.

from google-maps-services-js.

yerycs avatar yerycs commented on June 12, 2024 2

Why don't maintainers create patch version to fix this issue? It is so discouragement to face error at the first time rather than getting response for GOOGLE MAP official sdk.

from google-maps-services-js.

wangela avatar wangela commented on June 12, 2024

If you would like to upvote the priority of this issue, please comment below or react on the original post above with 👍 so we can see what is popular when we triage.

@abdirahmn1 Thank you for opening this issue. 🙏
Please check out these other resources that might help you get to a resolution in the meantime:

This is an automated message, feel free to ignore.

from google-maps-services-js.

victorighalo avatar victorighalo commented on June 12, 2024

Same error on node v20 and osx

Found a solution?

from google-maps-services-js.

justAsascha avatar justAsascha commented on June 12, 2024

Why don't maintainers create patch version to fix this issue? It is so discouragement to face error at the first time rather than getting response for GOOGLE MAP official sdk.

Feel free to contribute. It's open source :)

from google-maps-services-js.

jcardenaslie avatar jcardenaslie commented on June 12, 2024

Same error on node v20 and osx

Found a solution?

You can simply npm install --save [email protected] to get rid of the problem temporarily

This worked for me

from google-maps-services-js.

arpithindukuri avatar arpithindukuri commented on June 12, 2024

This answer works if you don't want to install a specific version as suggested above.
https://stackoverflow.com/a/72555437/14804912

After searching a lot, what works for me was what I found in this blog post:

https://blog.csdn.net/Missbelover/article/details/123221351

Basically, what you need to do is...

Remove all your node_modules dependencies.
npm rm -rf node_modules

Install core-js first.
npm install --save core-js

Finally install everything else.
npm install
yarn install

After this everything should work as expected, a least for me is working now.

Have a good day!

Thanks to Gustavo Villarroel C from Stack Overflow!

from google-maps-services-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.