Comments (19)
-Door +Some
from gvr-unity-sdk.
This seems like a good idea, although the results could vary across phone models. Maybe the brightness level should be a user control (through the settings button), and all the SDK needs to do it make sure it is constant.
from gvr-unity-sdk.
Each way had drawbacks and benefits. I'll vote with your choice. Could you just confirm that next release will not push brightness to max? Do that I don't rebuild my lightmaps for nothing 😀. It's really a pain to tune!😂
from gvr-unity-sdk.
-vote +cope 😴
from gvr-unity-sdk.
Not setting brightness to max is easy to do. In the short term, it can be a developer setting. That ought to be deliverable in the very near future. (Notice I am not actually committing -- not allowed to.)
from gvr-unity-sdk.
Thanks for the feedback. That's kind. I'll wait for a few days and see if something pops out before reworking lightmaps in Alien Apartment (my app).
PS: I posted also on G+ about this "issue": https://plus.google.com/108926424989499203010/posts/dbcqzp8MTZA
Cheers!
MiCk.
from gvr-unity-sdk.
I had a look into the activity class (for the other issue) and saw brightness is set to 55f... Don't you meant .55f?
Cheers.
MiCk.
from gvr-unity-sdk.
Interesting. It is set to 1.0f in code.
from gvr-unity-sdk.
Interesting. After tons of unity bugs now we have bugs in eclipse decompiler...
from gvr-unity-sdk.
...Or not..
private void startImmersiveMode();
[...]
10 putfield android.view.WindowManager$LayoutParams.screenBrightness : float [55]
Sorry it seems I'm a pretty bad disassembled bytecode reader :(
(misinterpreted 55 as a value instead of a pointer).
Anyway, I'm still interested in having this value being adjustable from Mono in the SDK.
Thanks for your support.
Cheers.
MiCk.
from gvr-unity-sdk.
Sorry for the delay in response. Things got pushed back. Adjustable brightness is still TBD.
from gvr-unity-sdk.
The more I think of it the more I see it as a killer function. I can imagine pushing lightness when player is in exterior and droping it when entering somewhere. That would be great!
from gvr-unity-sdk.
So, I sorta solved this by adding my own plugin which inherits GoogleUnityActivity and changed the brightness to follow user's setting on the onCreate() function. So far I don't see any problem with it.
@smdol could you foresee any problem from inheriting the activity? Well, other than the not-future-change-compatible of course.
from gvr-unity-sdk.
That seems like it will work, aside from future compatibility.
from gvr-unity-sdk.
Hi @smdol!
Nothing around luminosity in 0.5.1?😕
Cheers.
MiCk.
from gvr-unity-sdk.
The release notes indicate that the luminosity change is out:
"The SDK no longer forces Android screen brightness to maximum, which was
introduced in v0.5."
https://developers.google.com/cardboard/unity/release-notes
On Friday, July 24, 2015, MiCkSoftware [email protected] wrote:
Hi @smdol https://github.com/smdol!
Nothing around luminosity in 0.5.1?😕
Cheers.
MiCk.—
Reply to this email directly or view it on GitHub
#35 (comment)
.
from gvr-unity-sdk.
Omg @ReedL I've read carefully and still missed it. Going on vacations today. I need it! 😊
from gvr-unity-sdk.
@smdol closing this issue.
from gvr-unity-sdk.
Heh, NP, glad your issue got addressed! Enjoy your vacation!
On Saturday, July 25, 2015, MiCkSoftware [email protected] wrote:
Omg @ReedL https://github.com/ReedL I've read carefully and still
missed it. Going on vacations today. I need it! 😊—
Reply to this email directly or view it on GitHub
#35 (comment)
.
from gvr-unity-sdk.
Related Issues (20)
- Not working for LWRP (only left eye rendered) HOT 4
- Building to iOS fails Unity 2019.3.0b + Google VR + Universal Render Pipeline
- Distortion Correction Toggling with Unity and Daydream
- Can it work for Gear VR? HOT 1
- ios 13 beta xcode11 without error log when running, but the splash screen pops out
- Detecting if a recenter event just happened appears to be broken HOT 1
- Still getting "GvrShimUnity: getControllerConnectionStatus device 0 api" even with [email protected] HOT 1
- HLS live 360 playback is distorted on Oculus Go HOT 2
- How to turn on deinterlace using OpenGL
- Mirage Solo instant preview "not connected to editor"
- Mirage Solo - Instant Preview "Not connected to editor"
- googleVR Scaling issue.
- GVR audio engine issue?
- Zoom in Cardbard
- Cardboard stereo view mask does not fit into a Xiaomi with display aspect ratio greater than 2.1
- Weird image glitch with Universal Rendering Pipeline HOT 6
- [Question] Is there a way to use the controller without displaying two eyes
- Arrow on iphone HOT 4
- Camera Viewport Rect
- Magic Window launches with offset
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gvr-unity-sdk.