Luminosity about gvr-unity-sdk HOT 19 CLOSED

-Door +Some

from gvr-unity-sdk.

This seems like a good idea, although the results could vary across phone models. Maybe the brightness level should be a user control (through the settings button), and all the SDK needs to do it make sure it is constant.

from gvr-unity-sdk.

Each way had drawbacks and benefits. I'll vote with your choice. Could you just confirm that next release will not push brightness to max? Do that I don't rebuild my lightmaps for nothing 😀. It's really a pain to tune!😂

from gvr-unity-sdk.

-vote +cope 😴

from gvr-unity-sdk.

Not setting brightness to max is easy to do. In the short term, it can be a developer setting. That ought to be deliverable in the very near future. (Notice I am not actually committing -- not allowed to.)

from gvr-unity-sdk.

Thanks for the feedback. That's kind. I'll wait for a few days and see if something pops out before reworking lightmaps in Alien Apartment (my app).
PS: I posted also on G+ about this "issue": https://plus.google.com/108926424989499203010/posts/dbcqzp8MTZA

Cheers!
MiCk.

from gvr-unity-sdk.

I had a look into the activity class (for the other issue) and saw brightness is set to 55f... Don't you meant .55f?

Cheers.
MiCk.

from gvr-unity-sdk.

Interesting. It is set to 1.0f in code.

from gvr-unity-sdk.

Interesting. After tons of unity bugs now we have bugs in eclipse decompiler...

from gvr-unity-sdk.

...Or not..

private void startImmersiveMode();
[...]
10 putfield android.view.WindowManager$LayoutParams.screenBrightness : float [55]

Sorry it seems I'm a pretty bad disassembled bytecode reader :(
(misinterpreted 55 as a value instead of a pointer).
Anyway, I'm still interested in having this value being adjustable from Mono in the SDK.

Thanks for your support.
Cheers.
MiCk.

from gvr-unity-sdk.

Sorry for the delay in response. Things got pushed back. Adjustable brightness is still TBD.

from gvr-unity-sdk.

The more I think of it the more I see it as a killer function. I can imagine pushing lightness when player is in exterior and droping it when entering somewhere. That would be great!

from gvr-unity-sdk.

So, I sorta solved this by adding my own plugin which inherits GoogleUnityActivity and changed the brightness to follow user's setting on the onCreate() function. So far I don't see any problem with it.

@smdol could you foresee any problem from inheriting the activity? Well, other than the not-future-change-compatible of course.

from gvr-unity-sdk.

That seems like it will work, aside from future compatibility.

from gvr-unity-sdk.

Hi @smdol!

Nothing around luminosity in 0.5.1?😕
Cheers.
MiCk.

from gvr-unity-sdk.

The release notes indicate that the luminosity change is out:
"The SDK no longer forces Android screen brightness to maximum, which was
introduced in v0.5."
https://developers.google.com/cardboard/unity/release-notes
On Friday, July 24, 2015, MiCkSoftware [email protected] wrote:

Hi @smdol https://github.com/smdol!

Nothing around luminosity in 0.5.1?😕
Cheers.
MiCk.

—
Reply to this email directly or view it on GitHub
#35 (comment)
.

from gvr-unity-sdk.

Omg @ReedL I've read carefully and still missed it. Going on vacations today. I need it! 😊

from gvr-unity-sdk.

@smdol closing this issue.

from gvr-unity-sdk.

Heh, NP, glad your issue got addressed! Enjoy your vacation!

On Saturday, July 25, 2015, MiCkSoftware [email protected] wrote:

Omg @ReedL https://github.com/ReedL I've read carefully and still
missed it. Going on vacations today. I need it! 😊

—
Reply to this email directly or view it on GitHub
#35 (comment)
.

from gvr-unity-sdk.