control variable used on defer about ineffassign HOT 1 CLOSED

Hi @amery .

Your code doesn't work the way you think it does. Arguments to deferred function calls are evaluated at the defer statement. You are always passing false to undoThingsUnless. Try passing &ok instead.

When you went to open this issue, did you see an issue template called "False positive"? Did you ignore it, and why? (E.g., are you not familiar with the term "false positive"?) I ask because I created that issue template for the sake of reducing spurious reports like this one — and yet here we are. Can you think of a better name for the issue template? I'd appreciate your feedback :)

from ineffassign.