source command does not have an escape sequence for the markdown about jishaku HOT 4 CLOSED

Discord recently added an interactive, syntax highlighted, file preview feature on the desktop and web clients.

As this is the most common usage vector for Jishaku, and the intuitiveness greatly exceeds home-rolled solutions, as of 9099fe0, Jishaku will now check the file upload limit and, if the source file content fits within it, will upload the content as a file instead.

This circumvents the need for escaping in this case, but in the case it does not fit, the handling has been changed to favor @iomintz 's implementation.

from jishaku.

I started implementing this by just making the jsk_source command replace all occurrences of ``` with ``\N{zero width space}`, but then I noticed that since FilePaginator also uses WrappedPaginator with a fenced code block, it might be better to place this escaping code inside a new commands.Paginator subclass that's used as the base for all other base Paginator classes. Something like this:

def __init__(self, ...):
    self.escape_code_blocks = False
    if '```' in prefix and '```' in suffix:
        self.escape_code_blocks = True

def add_line(self, line):
    if self.escape_code_blocks:
        line = line.replace('```', '``\N{zero width space}`')
        super().add_line(line)

Let me know what you think @Gorialis

from jishaku.

i have earlier used discord.utils.escape_markdown from the discordpy library in my project isn't it possible to use that function?

from jishaku.

I merged #92 a while ago, but I realized in auditing later that it actually produces a lot of formatting inconsistencies (all underscores get "escaped"). I'll probably end up favoring this implementation, but we'll see how it goes when I have time to do some proper QA.

from jishaku.