Giter VIP home page Giter VIP logo

Comments (6)

aleayr avatar aleayr commented on September 16, 2024

Comment from @fribibb:

GOVCMS-121-images.zip
See attached zip file for optimised images to be used.

from govcms7.

aleayr avatar aleayr commented on September 16, 2024

Comment from @fribibb:

Alternatively we could use font icons such as font awesome or http://perfecticons.com/

from govcms7.

ruwanl avatar ruwanl commented on September 16, 2024

@fribibb can you please provide images for email, flickr and vimeo and all of the images in svg format please.

from govcms7.

fribibb avatar fribibb commented on September 16, 2024

ok, current status on this is @ruwanl has implemented ~85% into the custom module, using the perfecticons font-icons method + updating markup to be UL/LI rather than DIVs. But we discovered that there is a contrib module within govCMS too - both modules are used on multiple live sites currently too.
So we'll discuss Monday to figure out whether to continue with custom or attempt to contribute back into the public module...

from govcms7.

ruwanl avatar ruwanl commented on September 16, 2024

Have gone through the current sites and it seems only one site is using the contrib module. Some sites have implemented the sharing via the theme and the rest either do not have social sharing or are using the custom govCMS module.

from govcms7.

aleayr avatar aleayr commented on September 16, 2024

@ruwanl @fribibb

So, what is the way forward here? We'll have to work with the current site using the contrib module to change what they're doing.

Can we make this change in the next release, move the site using it to the new sharing icon method, and then remove the module in the release afterwards?

from govcms7.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.