Comments (4)
This approach can break under several circumstances:
- When
vulkan_win32.h
is changed and makes use of additional Windows types: they're not found. - Those
typedef
s are, strictly speaking,windows.h
implementation details: They may change in some future SDK update. - There may be some other conflicts if
windows.h
is included before or after that bit.
While you may be able to live with the limitations, they're somewhat unsuited for a header that should work in a wide variety of projects.
from vulkanmemoryallocator.
Yes these are the risks. Other popular vulkan libraries opted to remove windows.h anyways because realistically, this should be extremely rare (if ever, in the lifetime of a major Vulkan version) and is trivial to fix.
I understand if the owners don't see it that way though.
from vulkanmemoryallocator.
If I wanted to get rid of windows.h
but keep VK_USE_PLATFORM_WIN32_KHR
, I might create a wrapper header that does something like you did above, with a #define VULKAN_H_
after #include <vulkan/vulkan_win32.h>
and immediately including vk_mem_alloc.h
. It should give the result you desire.
If you name your wrapper vk_mem_alloc.h
(with the "real" header named differently, of course) you'll even get a transparent solution.
from vulkanmemoryallocator.
In my opinion @res2k is right. The solution proposed is a hack and may not be reliable or future-proof. If Vulkan header includes "windows.h" then please contact the developers of Vulkan SDK with request to change that.
Many Windows applications include and use "windows.h" anyway. To speed up compilation under Visual Studio I recommend putting it in precompiled header.
from vulkanmemoryallocator.
Related Issues (20)
- missing VMA_LEN_IF_NOT_NULL in vmaCopyMemoryToAllocation/vmaCopyAllocationToMemory HOT 1
- Buggy mapping hysteresis optimization HOT 2
- Asserts on Android 9 wth vkGetPhysicalDeviceMemoryProperties2KHR HOT 2
- no support for `VkBufferUsageFlags2CreateInfoKHR` HOT 2
- Specify in documentation that individual pools can be individually used w/o external synchronization HOT 1
- Compatibility issue with Vulkan 1.2.198 on OSX HOT 3
- Can I batch all allocations in one function call to VMA if I know my memory requirements upfront? HOT 2
- Building VulkanMemoryAllocator for C HOT 2
- Changes to PFN_vmaAllocateDeviceMemoryFunction HOT 1
- do not create a dummy buffer and destroy when call vmaFindMemoryTypeIndexForBufferInfo HOT 2
- Validation layer error in sample application HOT 5
- Problem when running tests of sample application on NVIDIA RTX 3090 HOT 5
- Use vkSetDebugUtilsObjectNameEXT to make debugging easier
- Question about 'Advanced data uploading' in the docs HOT 5
- C++20 module HOT 1
- VmaAllocator_T::Map illegal use of [[fallthough]] HOT 1
- Remove unused BasicTestBuddyAllocator()? HOT 3
- Write a new test which covers 'advanced data uploading' from docs HOT 5
- Clarify docs and improve pool API thread-safety guarantees if possible HOT 2
- Introduce a CMake option which allows VMA_DEBUG_LOG to be enabled easily HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vulkanmemoryallocator.