Giter VIP home page Giter VIP logo

Comments (13)

robin-francois avatar robin-francois commented on May 29, 2024 2

Disclaimer: I am not part of the developing team, just a user of crab.fit that wants it to work properly and be a true alternative to when2meet.

Crab.fit relies on the dayjs library for this functionality. Maybe you should have a look if the library is responsible for the behaviour you describe. And maybe the library should be updated if the issue has been corrected there.

Etc/GMT+2 is actually -02 according to the IANA database. That does not explain all the issue, but maybe some timezones do not match what their names indicate.

from crab.fit.

GRA0007 avatar GRA0007 commented on May 29, 2024 2

Thanks @robin-francois, and @astrojuanlu for reporting this. Sorry I've been focusing on work projects lately and haven't had the time I'd like to work on Crab Fit.
I'll look into dayjs, it's possible I simply need to update to a newer version. The list of timezones I'm using may also not be fully supported by dayjs.

from crab.fit.

astrojuanlu avatar astrojuanlu commented on May 29, 2024 2

Did a quick test, and it worked with Europe/Madrid and America/Buenos Aires, Europe/Amsterdam, Europe/London 👍🏽 Updating the issue title

from crab.fit.

robin-francois avatar robin-francois commented on May 29, 2024 1

There are several tickets open on the dayjs repository about timezone issues, more precisely around UTC/GMT:
iamkun/dayjs#1843
iamkun/dayjs#1606

Issues could be upstream.

from crab.fit.

GRA0007 avatar GRA0007 commented on May 29, 2024 1

Thanks @robin-francois. I've updated all dependencies in Crab Fit including day.js, however if these issues exist in that library this is likely an issue we'll have to wait for them to resolve. In the meantime, I'd suggest using city-specific timezones, e.g. here in Australia I use Australia/Sydney rather than Etc/GMT+10. Just be wary of daylight savings.

I have looked into other date/time libraries for JavaScript, however day.js is still the best option based on package size and functionality. I'll leave this issue open for now, hopefully these issues can be fixed in the day.js code.

from crab.fit.

robin-francois avatar robin-francois commented on May 29, 2024

Thanks for that. I hope @astrojuanlu can still enjoy using crab.fit despite some timezone oddities due to upstream libraries (and confusing timezone names).

from crab.fit.

astrojuanlu avatar astrojuanlu commented on May 29, 2024

Hi @robin-francois, thanks for staying on top of this. Unfortunately this is quite critical so for now I'm left with no alternative other than when2meet. It's unfortunate that dayjs has not solved these issues but the end result is that crab.fit is not usable.

from crab.fit.

robin-francois avatar robin-francois commented on May 29, 2024

Have you tried not using Etc/* timezones? As I said, those seem to be misleading by design.

from crab.fit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.