Comments (2)
cyriltovena
commented on June 21, 2024
I think this requires a big refactoring on parquet iterators, we need a way to produce one iterator per rowgroup. Then use this merge https://github.com/grafana/phlare/blob/63d522a723082453d54b1ece0a462f86887fac66/pkg/iter/profiles.go#LL38C27-L38C27
from phlare.
cyriltovena
commented on June 21, 2024
Actually just looked into this again and we actually don't have a bug, we load all profiles in memory for a given block when selecting profiles and merge them.
see https://github.com/grafana/phlare/blob/main/pkg/phlaredb/block_querier.go#L948-L975
So in the end no bug.
from phlare.
Related Issues (20)
- Loss of data on restart HOT 3
- SelectMerge latency is high HOT 3
- Stack trace symbols resolution is slow HOT 2
- Improve delta diff in Grafana Agent
- Query time splitting HOT 1
- Pyroscope ingest endpoint status code HOT 1
- Query from object store
- Routing doesn't keep query params
- Only start ui server when all services are ready in single binary mode HOT 1
- Preload blocks for x amount of days per tenant
- <https://github.com/grafana/phlare/issues/728>
- Add storage-gateway component to default micro-services
- When ingesting with duplicate labels, send error back to the client HOT 3
- Implement `SelectProfile` using `BlockQuerier`
- ARM build is broken HOT 1
- `service_name` label should determine series order HOT 1
- StacktraceResolver returns a non-requested stacktraceID HOT 1
- Improve Locations in memory representation HOT 1
- Sort Rows by Series when flushing to disk HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phlare.