Giter VIP home page Giter VIP logo

Comments (4)

lcrh avatar lcrh commented on September 21, 2024

By the way, I really appreciate the work that went into this. wrapt has been invaluable for building enact. We use it for wrapping python code to perform automatic telemetry and replays, e.g., to search the space of program executions of a non-deterministic python program, which comes in handy in the context of working with LLMs.

from wrapt.

GrahamDumpleton avatar GrahamDumpleton commented on September 21, 2024

Can you explain better why it is a problem for you and what you are trying to do?

Since you are using () and triggering a call the behaviour is as I would expect, including the error.

If you want the wrapped function to be tolerant of bogus arguments you should use:

@passthrough
def foo(*args, **kwargs):
  print('foo')

or filter them out in passthrough decorator wrapper function when calling the wrapped function.

@wrapt.decorator
def passthrough(wrapped, instance, args, kwargs):
  # Ignore all arguments.
  return wrapped()

from wrapt.

lcrh avatar lcrh commented on September 21, 2024

It's not the behavior that I expected, since I assumed that a decorator such as passthrough would not change the semantics of the function it wraps. My use case is related to telemetry, so maybe let's take logging as an example.

import logging

@wrapt.decorator
def log_calls(wrapped, instance, args, kwargs):
  logging.info('%s called with %s / %s', wrapped, args, kwargs)  
  return wrapped(*args, **kwargs)

I would have assumed that the intended contract is that annotating any function in a python program with log_calls does not change the behavior of the program, except for the additional logging.

It appears this is not the case.

E.g.:

def foo():
  print('foo')

def my_code(fun):
  class A:
    _fun = fun
  A._fun()

my_code(foo)  # succeeds for unwrapped functio
my_code(log_calls(foo))  # fails for wrapped function

from wrapt.

GrahamDumpleton avatar GrahamDumpleton commented on September 21, 2024

Okay, am overlooking that you pointed out error arises from internal to wrapt and not when called by the wrapper.

Let me think about it and I'll do some tests.

from wrapt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.