Giter VIP home page Giter VIP logo

Comments (2)

ecwyne avatar ecwyne commented on May 14, 2024

Implemented in #56

I do, however, want to express my concerns about using extraContext. The only reason for extraContext is if data sources use what's made available in extraContext. This puts the onus on the gateway author to make sure that it's there.

I would argue that it makes more sense to say to a data source developer "If you need something to be in context then put it in context yourself so you know it's there for sure"

from gramps--legacy.

jlengstorf avatar jlengstorf commented on May 14, 2024

I see where you're coming from, and I think any public data source should follow that pattern. However, I think there's a use-case for extraContext on internal projects where things like session management are handled in a central place.

At IBM, for example, we have internal APIs that require special tokens and privileges to operate. These are used by multiple data sources. If we didn't pass them in as extra context, we'd need to install and manage those internal APIs as dependencies in each data source rather than managing them at the gateway level and passing them down to all data sources.

We could always attach it to req, but I like the idea of being more explicit about it.

Does that all make sense? I've been staring at this for a long time, so it's possible there's a simpler solution I'm not seeing.

from gramps--legacy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.