Comments (2)
Implemented in #56
I do, however, want to express my concerns about using extraContext
. The only reason for extraContext
is if data sources use what's made available in extraContext
. This puts the onus on the gateway author to make sure that it's there.
I would argue that it makes more sense to say to a data source developer "If you need something to be in context
then put it in context
yourself so you know it's there for sure"
from gramps--legacy.
I see where you're coming from, and I think any public data source should follow that pattern. However, I think there's a use-case for extraContext
on internal projects where things like session management are handled in a central place.
At IBM, for example, we have internal APIs that require special tokens and privileges to operate. These are used by multiple data sources. If we didn't pass them in as extra context, we'd need to install and manage those internal APIs as dependencies in each data source rather than managing them at the gateway level and passing them down to all data sources.
We could always attach it to req
, but I like the idea of being more explicit about it.
Does that all make sense? I've been staring at this for a long time, so it's possible there's a simpler solution I'm not seeing.
from gramps--legacy.
Related Issues (20)
- Async context HOT 1
- An in-range update of nodemon is breaking the build 🚨 HOT 9
- Update edit links on https://gramps.js.org
- The addResolveFunctionsToSchema function takes named options now HOT 2
- An in-range update of graphql-upload is breaking the build 🚨 HOT 1
- Merging efforts with The Guild HOT 1
- Add typings for TS users working with GrAMPS HOT 1
- Conditional stitching to specific datasources
- Type namespace prefixes HOT 1
- Context differences between top-level and stitching resolvers HOT 17
- Use with Schema Stitching HOT 22
- Class methods are lost when spreading over context HOT 3
- How is gramps different from `graph-tools` schema stitching? HOT 5
- Using a GraphQL datasource
- Plugin API for data sources
- Calling `gramps()` with no arguments causes an error HOT 2
- Update ibm.biz links to git.io or other public link
- Using prepare and extraContext is confusing
- Version 10 of node.js has been released
- Documentation / Examples are not up to date on https://gramps.js.org/ HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gramps--legacy.