unarchive(objectForKey:) should throw about strongbox HOT 9 CLOSED

I Just re-read what you wrote. Yah, if you change the name of the class your trying to decode, that's a problem in your code. Making this api throw is a breaking change, meaning it would be incompatible with previous versions. I'll have to think about this more carefully.

from strongbox.

I think I'd rather add a new API that throws, instead of changing this existing API. That would not break existing implementations...

from strongbox.

I am not sure that making this api throw is the solution to your issue. Does the class MyOldTargetName (or whatever your class is named) confirm to NSSecureCoding?

from strongbox.

@granoff Another option may be to leave existing method w/o any changes and just introduce another with throw. WDYT?

from strongbox.

@granoff
Am also facing the same issue.

Below is the trace.

Is there any fix for this?

from strongbox.

@alexeylubyanoy Can you give me a little more detail about what your code looked like before you changed the module name, and then what the code looked like after you changed the module name and you got the crash you reported?

I am trying to write some unit tests to replicate the issue before I try to change any of the APIs in the library.

from strongbox.

import Security
import Strongbox
import Foundation

@objc class Credentials: NSObject, NSSecureCoding {
    static var supportsSecureCoding: Bool = true

    func encode(with aCoder: NSCoder) {
        aCoder.encode(username, forKey: "username")
        aCoder.encode(password, forKey: "password")
    }

    required init?(coder aDecoder: NSCoder) {
        guard
            let username = aDecoder.decodeObject(forKey: "username") as? String,
            let password = aDecoder.decodeObject(forKey: "password") as? String else {
            return nil
        }

        self.username = username
        self.password = password

        super.init()
    }

    @objc let username: String
    @objc let password: String

    @objc init(with username: String, password: String) {
        self.username = username
        self.password = password
    }
}

@objc class KeychainHelper: NSObject {
    @discardableResult
    @objc class func store(credentials: Credentials) -> Bool {
        KeychainHelper.removeCredentials()

        return Strongbox().archive(credentials, key: "defaultUser")
    }

    @objc class var storedCredentials: Credentials? {
        return Strongbox().unarchive(objectForKey: "defaultUser") as? Credentials
    }
}

So, nothing special here.

Issue appears when I call following code with old target name

let creds = Credentials(with: "username", password: "password")
KeychainHelper.store(creds)

and then change target name to the new one and call

let creds = KeychainHelper.storedCredentials

Please let me know if you need more details.
My workaround so far is to modify project settings to hardcode module name, so module name remains despite target name changed

from strongbox.

A couple more thoughts. The bundle identifier is integral to storing the data in the keychain if you do not specify a key prefix yourself. So if your target changed, then the bundle identifier changed. You can get around this by initializing your Strongbox instance with a keyPrefix argument:
Strongbox(keyPrefix: <the-old-bundle-identifier>). That might solve your problem.

I'm also curious about what your KeychainHelper.removeCredentials() method is doing. Strongbox has a convenience remove method for this purpose, and understands the key prefix stuff too.

from strongbox.

@discardableResult
    @objc class func removeCredentials() -> Bool {
        return Strongbox().remove(key: "defaultUser")
    }

from strongbox.