Giter VIP home page Giter VIP logo

Comments (6)

grantjenks avatar grantjenks commented on August 22, 2024

"throttle" seems to be a good one-word name. Other considered: "meter", "pace", "tempo", "rhythm". Some googling shows that throttling requests is more common than other terms.

from python-diskcache.

grantjenks avatar grantjenks commented on August 22, 2024

See also the stampede lock code in the diskcache directory.

from python-diskcache.

grantjenks avatar grantjenks commented on August 22, 2024

Tested pseudocode:

def throttle(count, seconds):
    """Throttle function calls to `count` times per `seconds`.

    """
    rate = count / seconds

    def decorator(func):
        last = time.time()
        tally = count

        @functools.wraps(func)
        def wrapper(*args, **kwargs):
            nonlocal last, tally
            while True:
                now = time.time()
                extent = now - last
                last = now
                tally += extent * rate
                if tally > count:
                    tally = count - 1
                    break
                elif tally < 1:
                    time.sleep((1 - tally) / rate)
                else:
                    tally -= 1
                    break
            func(*args, **kwargs)
        return wrapper
    return decorator

I'm doubtful this can be made multi-threaded with the atomic methods provided by diskcache. But maybe it can be good-enough.

from python-diskcache.

grantjenks avatar grantjenks commented on August 22, 2024

Design notes: throttle should be method on Cache objects that accepts key, count and seconds. The throttle method should use a transaction to calculate how long to sleep before asking again. If returned value is zero then perform action immediately.

Maybe there should be a Throttler object that uses the throttle method instead.

FanoutCache should also have throttle method but acts instead as decorator and handles retries for Timeout error. Django Cache ha same method that behaves identically.

Maybe have rate-limit method and throttle. One acts as low-level sleeper function, other acts as decorator. Yes, better to have separate methods.

from python-diskcache.

grantjenks avatar grantjenks commented on August 22, 2024

It would be nice to have an API for measuring the rate of something. Use case idea: better health checks. I think it could be implemented as a leaky-bucket with an un-bounded size. Return value is bucket size. Measure in calls per second.

from python-diskcache.

grantjenks avatar grantjenks commented on August 22, 2024

This is now included in the recipes. Commit reference bf7196d

from python-diskcache.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.