metadata about pdfviewer HOT 9 CLOSED

@thestinger

I've implemented an menu option to view document properties here (almost finished):
79ae289

Here's a screenshot:

Are the visuals ok like this? (Displayed metadata matches the PDF.js demo)

Additionally, i made some further UI changes (Opening the document is now a Floating Action Button, Menu is being hidden initially). Should i pr them too? (I think the UI could use some overhauling to make it prettier)

from pdfviewer.

Yes, that looks like a good start. It doesn't need to be perfect to be a useful improvement.

from pdfviewer.

Additionally, i made some further UI changes (Opening the document is now a Floating Action Button, Menu is being hidden initially). Should i pr them too? (I think the UI could use some overhauling to make it prettier)

That makes sense, but I wouldn't want that floating button there after a document is open.

from pdfviewer.

Of course. The button gets hidden once a PDF is opened.
The benefit with the Floating Button is that the menu item disabling stuff can be removed and the action bar menu can be hidden initially.

However, there's still a lot of room for changes / improvements:

• With the Floating Button present the menu could be reworked to replace the "open document" menu item with something like "close document", which would then proceed to close the current PDF and go back to initial screen (in my opinion this would be superior to keeping the "open document" item, however would need additional code which handles closing the PDF (i'm not too familiar with javascript))
• There's a lot of unused space initially, could be used to implement f.e. a recyclerview which shows most recently opened files or something else
• Possibly more + the stuff on the issue tracker

from pdfviewer.

I'm not sure if I want that floating action button but the metadata display is definitely wanted.

from pdfviewer.

@thestinger
I forgot to mention: The floating button would add a dependency on the design support library, so i presume it's out.
I've simply decided to hide all menu items except for "open document" initially, what do you think about it?
(https://github.com/Applications-Development/platform_packages_apps_PdfViewer/commit/6b844e000f779c9f0d44e0fbb59c464f45c88f73)

Would also allow dropping some ugly code.

from pdfviewer.

Design Support library, etc. are in AOSP so that's fine.

from pdfviewer.

Hiding them seems like a good approach.

from pdfviewer.

Alright, good to know, so i can overhaul https://github.com/CopperheadOS/platform_packages_apps_PdfViewer/pull/17 and use a more modern edit text.
I'll wait for you to review the existing pr's, before sending out more (there are few more incoming).

from pdfviewer.