Comments (12)
Both the previous and next page buttons are outside of the expanded menu, at least if you aren't on some tiny screen.
from pdfviewer.
Please provide a screenshot because it shouldn't be that way. If it's due to using it on a tiny screen size, I don't think there's much we can do about it.
from pdfviewer.
Thank you for your reply.
My device is Google Pixel 4a (5G) with the latest GrapheneOS Stable after update check.
Screenshot has been attached.
from pdfviewer.
I'm not able to reproduce it. Both buttons are visible here. It looks like you've increased Display size to Large from Default and it's only able to display 2 buttons in the action bar rather than 3. I don't know if there's anything we can do about it. Maybe we can configure it to more aggressively display buttons in the bar regardless of available space. It's very conservative right now.
from pdfviewer.
I checked and can confirm that you are correct. I did increase the display size to Larger, due to the small button and menu size on the phone. After decreasing the display size to Large, the next page button has appeared in PDF Viewer.
I am surprised by the aggressiveness of the button hiding, because there is enough space for 1-2 extra buttons at the top of PDF Viewer screen. Whether PDF Viewer is adjusted for this issue or not, I thank you for your assistance.
from pdfviewer.
I think that this is just how the action bar UI that it uses works including in other apps. It's able to display more than just the previous and next buttons as action buttons too, it's just that there's never enough room for it to want to do it.
from pdfviewer.
We can see if we can configure it to show more buttons. I've already wanted to do that in the past because it's inconvenient needing to use the menu for actions beyond prev/next too. I didn't see any easy way to do it when I checked before and I don't know if there's some other androidx library, etc. we could use to provide it. I don't want a custom action bar implementation.
from pdfviewer.
I agree. Personally, if I was adding a third button to the action bar, I would choose either Open document or Jump to page. Open document is likely the most suitable candidate for this.
from pdfviewer.
Yes it would just do it based on the order in the menu.
from pdfviewer.
It already supports it, and I already added button icons for most of them so that they could be displayed in the action bar at least in landscape mode or a tablet. It doesn't make sense to me that it's so conservative, but I wasn't the one who decided that and don't know how to change it.
from pdfviewer.
That's what I was thinking. The fact that Open document is first in the menu list is convenient.
I agree with your opinion on how conservative it is. I also noticed that, as you stated earlier, other apps have the same button hiding problem which has been at least partially fixed by lowering my display size. Android is too strict with the button hiding. It is not great for people who require larger display sizes due to visual impairment etc.
from pdfviewer.
I will search around both the internet and the OS code to try to find possible ways of fixing this problem. Currently, I am nowhere near as experienced as you with matters such as this, but I have some basic knowledge and understanding of code.
I will update this issue if I find anything, unless you specify a preferred method.
from pdfviewer.
Related Issues (20)
- Supporting continuous paging i.e. reading the whole document by just scrolling HOT 1
- Add submodule tag updates to dependabot HOT 1
- App freezing, weird zoom behaviour, and lag with some PDFs HOT 4
- Show document title in top app bar
- Cannot built the app HOT 5
- Scroll to go next/previous page like Google drive pdf viewer..
- App not supported HOT 1
- Possible to enter page to jump to HOT 1
- Make llight theme seamless just like dark theme.
- Add support for verifying at least a hash of pdf.js HOT 1
- Support for document dark theme
- Raise the minimum SDK for PDF Viewer from Android 8 to at least Android 9 or 10
- Markup/Editor option (enhancement)
- Page selector should be an input field HOT 2
- File Properties Dialogue Legiblity
- Improve Animations HOT 1
- PDF Page Persistence HOT 2
- Adaptive background color viewer background
- Consider updating com.android.application to 8.2.0 and com.google.android.material:material to 1.11.0
- Swipe for next/previous page HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pdfviewer.