Comments (5)
I'm not a fan of "tagging for the router" but in this case I think opening "hours" is the wrong way to tag something like this and instead conditional restrictions should be used, which we support.
(Soon we'll ignore this for foot too, but will show this in the path details for GH Maps)
from graphhopper.
@karussell Thank you for pointing this out. Would access:conditional=no @ (Nov-Mar)
be the correct way to tag a seasonal temporary pontoon bridge?
from graphhopper.
Or would bicycle=designated
and foot=designated
overwrite access:conditional=no
?
In that case, would the following be correct?
access=no
foot:conditional=designated @ (Apr-Oct)
bicycle:conditional=designated @ (Apr-Oct)
from graphhopper.
The tagging would then look good IMO, yes ... now I just looked in the rather complex definition of opening_hours it seems that the current tagging Apr-Oct
is not wrong and the evaluation tool just says "Please add a time selector to this rule". So not sure.
Now regarding conditional restrictions: for GraphHopper we currently only support yes
or no
(and not designated
) but this is something that we can fix. Still, as I indicated before, even when we fix this, the road will always stay accessible and we'd only show a warning in GH Maps and you could block it via using a special custom model. The reasoning behind this behaviour is discussed in this issue.
Furthermore this would mean e.g. for openstreetmap.org:
- there would be no warning (they do not show path details) and
- there is no possibility to block the way (they do not have custom model support).
from graphhopper.
For now I close this issue as we do not plan to add opening_hours support.
from graphhopper.
Related Issues (20)
- Inaccurate instruction to "turn onto" a road when a user is already on the road. HOT 8
- Routing wrong if change edge encoder access at caculate weight edge HOT 2
- Please provide better upgrade instructions between major versions HOT 7
- Route: Legs information empty in Java API
- Isochrone: No buckets when using public transport
- I just finished translating all zh_CN & zh_HK HOT 1
- Default bicycle profile ignoring turn restrictions? HOT 2
- Tags vehicle=no + bicycle:conditional=yes@… should trigger warning instead of failing to route in cycle profiles HOT 3
- Bike priority determination problem for tag combination of `cycleway:left` and `cycleway:right`
- GHUtility's method not found
- LMApproximator overhead HOT 3
- Benchmark stops with PointOutOfBoundsException HOT 5
- make `edges` byte-based
- highway=cycleway + access=no + bicycle=NULL is used for routing HOT 7
- should locked=yes have lower priority? HOT 4
- Default MaxWeight resolution is insufficient for truck routing HOT 11
- bad u-turn on road with turn restriction
- correctness vs. speed: astarbi.epsilon
- Snapping to turn restriction via-edges yields bad routes HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from graphhopper.