Giter VIP home page Giter VIP logo

Comments (5)

benjie avatar benjie commented on June 10, 2024

All those should be optional pgSimplifyPatch?: boolean;

I don't know about a @default annotation - have a look at the TSDoc docs 👍

from pg-simplify-inflector.

benjie avatar benjie commented on June 10, 2024

(Also the inflectors themselves need to have a this: Inflector, argument added as their first argument, python-style (otherwise this is treated as an any)

from pg-simplify-inflector.

ab-pm avatar ab-pm commented on June 10, 2024

Ah, right, I forgot about making them optional because PostGraphileOptions has a Partial<GraphileBuildOptions> anyway.

from pg-simplify-inflector.

ab-pm avatar ab-pm commented on June 10, 2024

Looks like TSDoc does not yet support this, the RFC is already implemented by https://api-extractor.com/pages/tsdoc/tag_defaultvalue/ though

from pg-simplify-inflector.

benjie avatar benjie commented on June 10, 2024

I'm going to close this as the TypeScript types won't be out until V5, and this repo is going to be moving to the graphile-engine monorepo as part of that and being rewritten into TypeScript so it'll become a redundant issue.

from pg-simplify-inflector.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.