Missing peer dependency warnings about node-graphql-server HOT 9 CLOSED

I'm not sure. There used to be an issue with multiple versions of graphql being installed at the same time. That's why the advice was to always make that a peer dep and install it only once, on the actual project level. So that would mean: add them in the boilerplate.

from node-graphql-server.

OK, just looked at this and it turns out there are some very significant breaking changes in [email protected] in several areas, so basically any tool based on graphql is going to have some things to work on to upgrade.

Unfortunately, there aren't release notes yet: https://github.com/graphql/graphql-js/releases/tag/v0.12.0

We're working on fixes for graphql-tools and hopefully will be able to maintain backwards compatibility, keep track here: ardatan/graphql-tools#541

from node-graphql-server.

As the dependencies on the boilerplates itself are set correctly now, and also for all directly related libraries (yoga etc.), this is now out of our control.

from node-graphql-server.

That's a good point. Do you have any opinion on whether this should be resolved in the boilerplates or in graphql-yoga?

Maybe @stubailo wants to share his thoughts?

from node-graphql-server.

I think this is because the new 0.12 graphql version was released, so we need to update our stuff to work with that, and list that in the peer dependencies. So I think this is actually npm working as needed.

from node-graphql-server.

Thanks for looking into this @stubailo 👏

from node-graphql-server.

@stubailo If you look at the warnings, they are all for <= 0.11.x, so I don't think it has to do with that. I believe it has to do with those packages specifying graphql as a peer dependency, so the dependency needs to be added to the consuming project explicitly.

from node-graphql-server.

I don't currently think so - you get the same warning for a wrong version that you get for a missing package. So my current diagnosis is that people who install the boilerplate are getting graphql 0.12, since nothing would work without it, but the peerDep thing is complaining about the version.

from node-graphql-server.

May be I face in same problem.

MSs-Mac-mini:twitter-app ms$ yarn add apollo-server-express graphql-tools
yarn add v1.3.2[1/4] 🔍 Resolving packages...
[2/4] 🚚 Fetching packages...
[3/4] 🔗 Linking dependencies...
warning "apollo-server-express > [email protected]" has incorrect peer dependency "graphql@^0.9.0 || ^0.10.0 || ^0.11.0 || ^0
.12.0".
warning "apollo-server-express > apollo-server-core > [email protected]" has incorrect peer dependency "graphql@^0.10.0 ||
^0.11.0 || ^0.12.0".
warning "apollo-server-express > apollo-server-core > [email protected]" has incorrect peer dependency "graphql@^0.10.0 || ^0.11.
0 || ^0.12.0".
warning "apollo-server-express > apollo-server-core > [email protected]" has incorrect peer dependency "graphql@^0.10.0 || ^0.11.0 || ^0.12.0".
warning " > [email protected]" has incorrect peer dependency "graphql@^0.11.0 || ^0.12.0".
[4/4] 📃 Building fresh packages...
success Saved 2 new dependencies.
├─ [email protected]
└─ [email protected]
✨ Done in 1.92s.

from node-graphql-server.