How do we use this with Entity Framework? about server HOT 16 CLOSED

Looks like a bug as the stream is completed as soon as all all of the rows are pushed out. Timing issue. I'll check if this is fixed in the release 3.0.0 branch.

from server.

This shouldn't happen with the 3.0

from server.

I'll try making a proper test came for it. To me it feels like a bug in Reactive extensions but have to see. The stream is completed while subscribe call hasn't returned yet.

from server.

@pekkah Thanks a lot. Much appreciated.

from server.

@pekkah Fantastic, I'll test it later tonight. Thanks again.

from server.

@pekkah I just upgraded to graphql server 3.0 alpha and I still get this error.

Microsoft.AspNetCore.Server.Kestrel[13]
Connection id "0HLCCVEES2JD9", Request id "0HLCCVEES2JD9:00000001": An unhandled exception was thrown by the application.
System.NullReferenceException: Object reference not set to an instance of an object.
at GraphQL.Server.Transports.Subscriptions.Abstractions.Subscription.OnCompleted()
at System.Reactive.SafeObserver1.OnCompleted() at System.Reactive.Linq.ObservableImpl.Catch2..OnCompleted()
at System.Reactive.Linq.ObservableImpl.SelectMany2.SelectManyImpl.OnCompleted() at System.Reactive.Linq.ObservableImpl.Select2..OnCompleted()
at System.Reactive.Linq.ObservableImpl.ToObservable1._.LoopRec(State state, Action1 recurse)
at System.Reactive.Concurrency.Scheduler.<>c__DisplayClass49_01.<InvokeRec1>b__0(TState state1) at System.Reactive.Concurrency.Scheduler.<>c__DisplayClass49_11.b__2(IScheduler scheduler1, TState state3)
at System.Reactive.Concurrency.ScheduledItem2.InvokeCore() at System.Reactive.Concurrency.ScheduledItem1.Invoke()
at System.Reactive.Concurrency.CurrentThreadScheduler.Trampoline.Run(SchedulerQueue1 queue) at System.Reactive.Concurrency.CurrentThreadScheduler.Schedule[TState](TState state, TimeSpan dueTime, Func3 action)
at System.Reactive.Concurrency.LocalScheduler.Schedule[TState](TState state, Func3 action) at System.Reactive.Producer1.SubscribeRaw(IObserver1 observer, Boolean enableSafeguard) at System.Reactive.Producer1.Subscribe(IObserver`1 observer)
at GraphQL.Server.Transports.Subscriptions.Abstractions.Subscription.Subscribe(SubscriptionExecutionResult result)
at GraphQL.Server.Transports.Subscriptions.Abstractions.SubscriptionManager.d__11.MoveNext()

from server.

Fix in 3.1.0-alpha0004

from server.

@pekkah Still getting the same issue in alpha 0004.

from server.

At least this test now passes b8ab618

Could you create a failing test case for it?

from server.

@pekkah It seems to be entity framework specific, is calling .ToObservable valid for this? I have no idea about Reactive to be able to understand what's going wrong here or create a failing test case.

from server.

What are you trying to do?

from server.

@pekkah Create a comment system that automatically updates when users create a new comment. Similar to twitch.tv comments system.

from server.

I mean how are you planning to implement it? Now you're just trying to push the whole comments table contents trough the websocket to the client.

from server.

I am not sure how I was going to implement it. I wanted to solve this issue and then play around with it.

At the moment I am just doing this:

`const subscription = graphql`
  subscription commentSubscription {
    commentAdded {
      id
    }
  }
`;

export default () => requestSubscription(
  environment, // see Environment docs
  {
    subscription,
    onError: error => console.error(error), // eslint-disable-line no-console
  },
);
`

and calling it in my app.js.

from server.

Actually I guess I don't even need Entity Framework for this if I don't care about preserving the comments right? I can just copy the sample chat schema where the comments will last until app restart which seems good to me.

I'll try that.

from server.

Closed due to inactivity. @MartinDawson I hope you solved the problem.

from server.