Giter VIP home page Giter VIP logo

Comments (4)

Cito avatar Cito commented on May 18, 2024 1

Thank you for the feedback. The idea behind graphql-core-next is to replicate the latest graphql.js as closely as possible.

It seems the same problem exists in graphql.js, and they're trying to fix it in 14.1.0 - build_schema and extend_schema are currently under heavy refactoring in graphql.js. I will migrate these changes then back to graphql-core-next.

If you still find something that works in the current graphql.js that does not work here, let me know.

You might also want to join the conversation over at graphql.js to push this forward.

from graphql-core.

Cito avatar Cito commented on May 18, 2024

Could you check if graphql-core-next 1.0.3 (based on GraphQL.js 14.2.1) is better in this regard?

from graphql-core.

rafalp avatar rafalp commented on May 18, 2024

Hi, thanks for coming back with this info!

I've did a quick test with graphql-core-next==1.0.3 and following SDL and its not working:

    type Query {
        year: Int
    }

    extend type Query {
        month: Int
    }

Following with the issue for GraphQL.js, it seems that their plan was to handle this by raising an exception when there's extend in SDL passed to build_schema: graphql/graphql-js#922

So I'm guessing we'll have to do custom implementation like how graphql-tools does it.

from graphql-core.

Cito avatar Cito commented on May 18, 2024

I'm closing this as I think this should be solved in GraphQL.js and we simply follow. As far as I understand, they want to support "extend type" in build_schema in version 15.

from graphql-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.