Comments (4)
Thank you for the feedback. The idea behind graphql-core-next is to replicate the latest graphql.js as closely as possible.
It seems the same problem exists in graphql.js, and they're trying to fix it in 14.1.0 - build_schema
and extend_schema
are currently under heavy refactoring in graphql.js. I will migrate these changes then back to graphql-core-next.
If you still find something that works in the current graphql.js that does not work here, let me know.
You might also want to join the conversation over at graphql.js to push this forward.
from graphql-core.
Could you check if graphql-core-next 1.0.3 (based on GraphQL.js 14.2.1) is better in this regard?
from graphql-core.
Hi, thanks for coming back with this info!
I've did a quick test with graphql-core-next==1.0.3
and following SDL and its not working:
type Query {
year: Int
}
extend type Query {
month: Int
}
Following with the issue for GraphQL.js, it seems that their plan was to handle this by raising an exception when there's extend
in SDL passed to build_schema
: graphql/graphql-js#922
So I'm guessing we'll have to do custom implementation like how graphql-tools
does it.
from graphql-core.
I'm closing this as I think this should be solved in GraphQL.js and we simply follow. As far as I understand, they want to support "extend type" in build_schema
in version 15.
from graphql-core.
Related Issues (20)
- Can subscriptions have middleware HOT 2
- Performance issues related to complete_value on large datasets HOT 3
- Significant performance hit when using async resolvers HOT 14
- Can you inject fields to an operation with a Visitor? HOT 2
- Use type guards for `language.predicates` HOT 1
- Trying to inject `id` field on every `selection_set` HOT 1
- Can default values form cycles? HOT 2
- Include name in representation of named nodes HOT 1
- performance issues due to breadth first execution of grapqhl queries in case of async resolvers during calls burst HOT 4
- A
- subscribe breaking change in graphql version 3.3.0a3 HOT 1
- [Question] How to map operation variables to their uses? HOT 2
- Using Relays in Graphql-core raises a TypeError HOT 4
- `out_name` is not respected for input objects used as default argument value
- Segfault during schema parsing HOT 3
- Segfault during schema parsing
- `graphql.utilities.print_schema` module contents are hidden behind `utilities` package
- `deepcopy` fails if the schema has a directive with an enum argument
- Both `typing.ByteString` and `typing.Text` are deprecated and slated for removal in Python 3.14 HOT 3
- Add the ability to specify `GraphQLResolveInfo.context` type HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from graphql-core.