Provide an obvious way to register custom scalar type implementations about graphql-core HOT 4 CLOSED

Hi @itkach, sorry for the late answer.

The reason why it works in the GraphQL.js example is because it sets the type like this:

Object.assign(schema._typeMap.MyScalar, MyScalar)

Note that this is different from simply setting _typeMap.MyScalar = MyScalar, because it keeps the MyScalar object and replaces only its properties. So all references to this type will see the changes as well. The direct equivalent in Python would be doing this:

schema.type_map["MyScalar"].__dict__.update(MyScalar.__dict__)

Or, you can do it like this:

my_scalar = schema.type_map["MyScalar"]
my_scalar.serialize = ...
my_scalar.pare_literal = ...
my_scalar.pare_value = ...

Or, create a function that copies these methods from one GraphQLScalarType to another.

from graphql-core.

@Cito Thank you for the explanation, I see now how it works. It's unfortunate that GraphQL.js thinks that mutating guts of an object inside of a not-quite-public other object is an acceptable API. I understand that graphql-core-next is a port, but perhaps there's a room for a better API here?

from graphql-core.

@itkach There is actually a better API for creating executable schemas from SDL, but it's in graphql-tools which is not part of GraphQL.js. It provides a function makeExecutableSchema that can add the resolvers to a schema given by SDL, and also allows using custom Scalar and Enum types.

It would be good to have something like that in Python, either as a separate package like graphql-tools or as a subpackage of graphql-core-next. I will create a ticket to move that forward.

from graphql-core.

But note that you can of course build executable schemas directly in graphql-core-next using the provided classes, as I have shown in the blog article above. This is considered the primary way of building them in graphql-core-next.

from graphql-core.