Exceptions in subscribe() are not handled by executor about graphql-core HOT 3 CLOSED

Here is repro: https://github.com/rafalp/graphql-core-next-30

from graphql-core.

Thanks for reporting. Will look into this when I find some time. Maybe you can also post some demo code that demonstrates the problem.

from graphql-core.

Hi @rafalp - finally found some time to look into this. I understand your problem, but as far as I see, this is the expected behavior and in line with the spec.

When you provide a response function to produce the response stream, then errors are in fact passed to the client (see points 5. and 6.) as part of the GraphQLResult. But the subscribe function in your example is used for creating the source stream. As far as I see, the specs do not say explicitly what should be done with errors in the source stream. But there is nothing about passing them to the response stream.

The reference implementation passes errors in the response stream to the client and errors in the source stream to the server. You can see this is the expected behavior in these tests in GraphQL.js: It should handle error during execution of source event but it should pass through error thrown in source event stream. Your example corresponds to the second test - that's why the error is passed through to you.

You could argue that the specs should be amended and errors should be handed over to the response stream. But you will need to create a GraphQL.js issue for this. The goal of graphql-core-next is to just replicate the behavior of GraphQL.js.

from graphql-core.