calling aclose() on a subscription doesn't cancel task about graphql-core HOT 6 CLOSED

Cool. Yeah, I'd love to get that merged in with this team and make it a shared project (I've reached out to @syrusakbary via email...).

from graphql-core.

There were some worthwhile additions to https://bugs.python.org/issue34730 that might be worth reading as we implement async gens (but I don't think that's a problem with async iters).

from graphql-core.

That's interesting. I have been also working on a new version of graphql-ws recently (not published yet). It includes the functionality from graphql-subscriptions and I want to add all the tests and the client code from graphql-ws as well. Maybe we can join our efforts.

from graphql-core.

Is this the graphql-subscriptions you're referencing?

I'm totally open to joining efforts. I'd like to sprinkle into that repository some brief documentation regarding usage, and then migrate the project to this team and I'd be happy to grant you write-access (@syrusakbary, thoughts?).

Thanks for your work with graphql-core-next!

from graphql-core.

Yes, that's the graphql-subscriptions I have included in my version of graphql-ws. In my implementation of with_filter I'm using a similar mechanism as you recently suggested to allow closing a filtered async iterable while it's running.

from graphql-core.

Closing this since I see no more actionable items for graphql-core-next. graphql-next-ws is a separate issue (still on my todo list).

from graphql-core.