Comments (4)
Should we do no prefix by default and let the user configure it?
from graphql-client.
That's the safest option probably, although I don't see a use-case for prefixing happening often anymore, since, if my memory is right, we already prefix the generated items with the query name, in addition to wrapping everything in a module. For example:
query People {
person(id: 1) { name }
}
Will generate a struct called RustPeoplePerson
. Fragments are also their own "roots". So collisions can happen but should be rare, so we could probably do custom prefixing, defaulting to nothing.
Example query that should collide with the generated ResponseData
without prefixing, for testing purposes:
query Response {
data
}
from graphql-client.
I was thinking, does ResponseData even need to be generated? Would it make sense to have another struct you annotate with #[derive(GraphQLResponse)
like GraphQLQuery
? Does that buy us anything?
from graphql-client.
Hmm, sorry for reacting to your last comment that late. Since a given ResponseData's fields are specific to one query, I don't think there is a way around generating it. I am not sure I understand entirely.
from graphql-client.
Related Issues (20)
- Deserializing ID as integer not String HOT 4
- Unable to get variables into graphql query? HOT 7
- Using Enum in query HOT 1
- Generating queries from async_graphql
- Use String deserialization for bigInt
- Fragments as Traits HOT 1
- Better handling of timeout error from GitHub with an invalid response body HOT 9
- Unable to use inline fragment - Complex data-type HOT 15
- CLI generates invalid query
- Support `@required` directive
- Add support for SDL schema download with cli
- Incorrect queries generated when document contains multiple operations HOT 1
- Default trait for variables
- Graphql insert mutation: omitting fields with default values
- Support for reqwest 0.12 ? HOT 4
- failed to parse schema HOT 1
- How to use `graphql_client` via a crate that re-exports it? HOT 1
- Deserialize unix timestamps into `chrono::NaiveDateTime` HOT 1
- Input `serde_json::Value` variable wrongly coerced to `String` HOT 1
- graphql_client_cli: warning suppression is missing a newline HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from graphql-client.