Giter VIP home page Giter VIP logo

Comments (4)

LegNeato avatar LegNeato commented on August 26, 2024

Should we do no prefix by default and let the user configure it?

from graphql-client.

tomhoule avatar tomhoule commented on August 26, 2024

That's the safest option probably, although  I don't see a use-case for prefixing happening often anymore, since, if my memory is right, we already prefix the generated items with the query name, in addition to wrapping everything in a module. For example:

query People {
  person(id: 1) { name }
}

Will generate a struct called RustPeoplePerson. Fragments are also their own "roots". So collisions can happen but should be rare, so we could probably do custom prefixing, defaulting to nothing.

Example query that should collide with the generated ResponseData without prefixing, for testing purposes:

query Response {
  data
}

from graphql-client.

LegNeato avatar LegNeato commented on August 26, 2024

I was thinking, does ResponseData even need to be generated? Would it make sense to have another struct you annotate with #[derive(GraphQLResponse)like GraphQLQuery? Does that buy us anything?

from graphql-client.

tomhoule avatar tomhoule commented on August 26, 2024

Hmm, sorry for reacting to your last comment that late. Since a given ResponseData's fields are specific to one query, I don't think there is a way around generating it. I am not sure I understand entirely.

from graphql-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.