Giter VIP home page Giter VIP logo

Comments (5)

rricard avatar rricard commented on April 19, 2024

Here is a quick fix if you want to continue to work before that issue gets fixed:

Add this to your .flowconfig:

[ignore]
.*/node_modules/graphql/lib/.*

EDIT Nope, it doesn't work. The imported module won't exist anymore for flow...

EDIT2 Add this to your Makefile or in a package.json hook or anything you want to use:

cd node_modules/graphql && find . -type f -print0 | xargs -0 sed -i '' 's/@flow//g'

This will strip the @flow from the GraphQL-js's files. Take this as a temporary solution.

from graphql-js.

leebyron avatar leebyron commented on April 19, 2024

Sorry about this. I will bring this up with the Flow team to get their best advice

from graphql-js.

rricard avatar rricard commented on April 19, 2024

Oh don't worry! I deactivated the error with my small sed regex. It will be
fixed when it needs to be. Thanks for bringing this up to the flow team on
this though! Again, I can write the patch if it's not top priority for you
at fb.

On Mon, Jul 6, 2015, 03:28 Lee Byron [email protected] wrote:

Sorry about this. I will bring this up with the Flow team to get their
best advice


Reply to this email directly or view it on GitHub
#25 (comment).

from graphql-js.

leebyron avatar leebyron commented on April 19, 2024

With the recent change to babel, the /*@flow*/ header is now removed, so hopefully this solves your issues.

I'll continue to look into nicer ways to improve this going forward.

from graphql-js.

angelf avatar angelf commented on April 19, 2024

It would be briliant to have flow annotations preserved. For instance in facebook/draft-js they leave the original code in /lib/ and place the generated plain javascript in /build/.

from graphql-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.