Comments (20)
Using formatError
as well, is there a way to pass the same error handler when using in testing? (in tests you most of the time query directly using the graphql object to execute the query with the schema.
import {
graphql,
} from 'graphql';
...
let resp = (await graphql(Schema, query, {}, context));
from graphql-js.
This seems to be fixed here: https://github.com/graphql/express-graphql/pull/45/files
graphiql: true,
formatError: (error) => ({
message: error.message,
details: config.isProduction ? null : error.stack
})
from graphql-js.
@bkoltai @alfaproject You can access original errors and their stack traces, like that:
const result = await execute(/* ... */);
if (result.errors) {
result.errors.forEach(err => console.log(err.originalError));
// ...
}
from graphql-js.
👍 Really hard to debug ATM.
from graphql-js.
I have currently the same problem. I'm not quite sure how to test my custom error messages. Or is it better to test the whole express-graphql endpoint for the error messages?
from graphql-js.
Yeah this would be useful. Maybe a dev flag which could be passed to the graphql
function during dev which exposes stack traces as well as error messages?
from graphql-js.
Yeah, I feel this pain as well. I have a broader error handling refactor I need to do that should help this be less painful
from graphql-js.
+1 on this.
from graphql-js.
This is killing me.
from graphql-js.
in error/formatError.js
I've added the line:
stack: error.stack,
to the JSON returned and it has helped tremendously.
from graphql-js.
+1 for this
Thanks for the tip, @johanatan! Lifesaver!
from graphql-js.
+1 good call johanastan
from graphql-js.
Now that #118 has been merged; what's the next step forward here? graphql/express-graphql#4 is closed but to my knowledge this issue is not resolved. How can we help?
from graphql-js.
+1
from graphql-js.
Has anybody patched this with #28 (comment) via @johanatan?
from graphql-js.
+1, also, @johanatan, thanks a lot. I've already made a statue from you
from graphql-js.
+1
from graphql-js.
Closing this since graphql-js no longer formats Errors anymore (the errors
field on the output is a list of the original Error
instances now).
Formatting is still recommended when using over a web endpoint, and express-graphql
does the simple thing by default and allows for customization.
from graphql-js.
Agreed, how do we get a stack trace for the errors reported from using the graphql
function directly, which I'm also doing in tests and get errors from my code with just the message and no trace.
from graphql-js.
Just stumbled upon this issue and not quite sure why is it closed. I only get the error title when invoking with graphql
or execute
...
from graphql-js.
Related Issues (20)
- FieldResolver performance HOT 2
- Inline fragment from an interface to an interface that extends it is invalid
- Resource exhaustion exploit when parsing queries HOT 7
- In GraphQL how to set WriteOnce functionality in specific property in the collection schema HOT 1
- Generator generates alias imports not compatible with TypeScript Type-Only Imports and verbatimModuleSyntax HOT 2
- Printing the @oneOf directive HOT 1
- Allow shallow sorting with lexicographicSortSchema HOT 2
- Passing arguments into the resolvers by just using `buildSchema` and `graphql`? HOT 3
- Error after upgrading from 16.6 to 16.8.1 with globalThis.process.env.NODE_ENV HOT 12
- Add: Link to new api docs in the README of this project.
- Introspection result missing interfaces
- Detect subscription successfully started HOT 1
- Errors thrown when iterating over subscription source event streams (AsyncIterables) should be caught HOT 2
- graphql resolver circular dependency type error (bi-directional relation) HOT 1
- Current main is up to 50% slower than previous major version HOT 10
- Type definition for `DefinitionNode` appears to be wrong HOT 4
- AST: `IntValueNode` and `FloatValueNode` store values as string HOT 2
- Array-type resolvers: an intuitive solution to the n+1 problem HOT 1
- Performance of stack traces in errors results in high response latency (>1 second) HOT 1
- Support for deep input graphs HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from graphql-js.