Giter VIP home page Giter VIP logo

Comments (6)

andimarek avatar andimarek commented on May 7, 2024 1

Looks great @leebyron.

I am not sure the full semver range serves us well: Maybe just two numbers (major and minor) is enough for us to start with?

The finer semantics of "backward compatible" are not always really clear: I found it much easier to just differentiate between: you should pay attention to it (major change) and you don't need to care (minor).

from graphql-scalars.

andimarek avatar andimarek commented on May 7, 2024 1

Coming back to this after more than two year: I strongly propose to keep it as simple as possible to get started.

I created a new PR #9 with a basic setup, which I intend to merge soon and iterate on it. We will probably go with a very manual URL schema like:

spec.graphql.org/<author-name>/<scalar-name>

This would be immutable and can't be changed after merged. We will probably allow editorial changes.

A new version of the scalar would need to be have a new scalar name, which might be <scalar-name>2, <scalar-name>3 etc.

In general we will very likely rely on manual reviews to get started. If that doesn't scale we might revisit the approach.

from graphql-scalars.

leebyron avatar leebyron commented on May 7, 2024

Up for discussion @graphql/graphql-scalars

from graphql-scalars.

eapache avatar eapache commented on May 7, 2024

I agree with Andi's point about versioning, and might even take it a step further - if the spec change is clearly not backwards compatible, is it even the same spec at that point? Should the new spec and the old spec really be sharing usage stats? I think that for most of the metadata/stats we might want for a spec, we'd really want them per major version, not shared across multiple major versions, in which case it might be simpler to follow the golang style and just say that a new major version should just be a new spec. This would still leave a single integer version for use for editorial changes.

The obvious con here is that we might end up with https://scalars.graphql.org/andimarek/datetime-v2/1. It's a bit gross, but not actually sure if it's a huge problem?

from graphql-scalars.

andimarek avatar andimarek commented on May 7, 2024

I created a first implementation for this Url system: #3

from graphql-scalars.

dondonz avatar dondonz commented on May 7, 2024

Closing this issue as we're going ahead with immutable specifications, although we will permit non-semantic edits such as typos. See #13.

We're proceeding with @andimarek's simpler naming proposal.

from graphql-scalars.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.