Giter VIP home page Giter VIP logo

Comments (2)

leebyron avatar leebyron commented on April 28, 2024

Thanks for this feedback. This is a lot, so let me try to address each point.

For colons in the type definition field arguments and variable definitions, we're hoping to do two things:

  1. Create a visual mirroring between the definition of the field arguments and the usage of them.
  2. More importantly, leverage existing knowledge of other languages where syntax works this way: Flow, TypeScript, Swift, amidst others.

is the dollar sign really required?

Yes, it syntactically avoids an ambiguity between a possible enum values and variables.

enum Color {
  red
  green
  blue
}

query coloredThing($color: Color) {
  variableThing: thing(color: $color)
  redThing: thing(color: red)
}

Also, variables have a different frequency and importance in a query language than they do in a programming language. When using a programming language, variables are often the most common token you use, so keeping them unadorned is important for legibility. In query languages, however, variables are fairly rare relative to data description identifiers. When variables are used, it's important to visually highlight them so that it's clear. We use the $ sigil as a way to visually identify variables.

from graphql-spec.

tristanz avatar tristanz commented on April 28, 2024

Makes sense, thanks.

from graphql-spec.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.