Giter VIP home page Giter VIP logo

Comments (14)

mattkasun avatar mattkasun commented on June 5, 2024

thanks will update

from homebrew-netclient.

mattkasun avatar mattkasun commented on June 5, 2024

PR #2 updates version in netclient.rb

tested on Darwin 21.4.0

working on a multi-arch version ---not quite there yet

from homebrew-netclient.

AlexKMDev avatar AlexKMDev commented on June 5, 2024

Thanks, it seems installation fails only on M1 then (it still outputs No such file or directory now)? I don't have an Intel mac, so I couldn't check.

from homebrew-netclient.

mattkasun avatar mattkasun commented on June 5, 2024

someone else got it to work on intel :)

I will do some more investigation on how to do M1 --- maybe it would be easier to have a netclient-M1 cask... would you be willing to test it?

from homebrew-netclient.

AlexKMDev avatar AlexKMDev commented on June 5, 2024

I will do some more investigation on how to do M1 --- maybe it would be easier to have a netclient-M1 cask... would you be willing to test it?

Of course, no problem.

from homebrew-netclient.

mattkasun avatar mattkasun commented on June 5, 2024

could the No such file or directory error be the result of #!/usr/local/bin/bash in the install script?

from homebrew-netclient.

AlexKMDev avatar AlexKMDev commented on June 5, 2024

could the No such file or directory error be the result of #!/usr/local/bin/bash in the install script?

Probably. I don't have bash at this path at all. Maybe it will be better to use something like #!/usr/bin/env bash (or even #!/bin/sh, I don't think bash is really required there) and $(brew --prefix) to figure out where homebrew is installed?

from homebrew-netclient.

mattkasun avatar mattkasun commented on June 5, 2024

still not sure how to put two binaries netclient-darwin and netclient-darwin-arm64 in a single cask

from homebrew-netclient.

AlexKMDev avatar AlexKMDev commented on June 5, 2024

You can try to build 2 tgz archives with each architecture with github workflows and then point to the corresponding archive in the cask file. Here is an example of how to check which architecture is used: https://github.com/Homebrew/homebrew-cask/blob/HEAD/Casks/ivpn.rb

from homebrew-netclient.

mattkasun avatar mattkasun commented on June 5, 2024

You can try to build 2 tgz archives with each architecture with github workflows and then point to the corresponding archive in the cask file. Here is an example of how to check which architecture is used: https://github.com/Homebrew/homebrew-cask/blob/HEAD/Casks/ivpn.rb

OK, I think I get it... On the todo list for tomorrow

from homebrew-netclient.

mattkasun avatar mattkasun commented on June 5, 2024

update available that should work on arm64 and amd64

from homebrew-netclient.

AlexKMDev avatar AlexKMDev commented on June 5, 2024

Still fails now because of brew-prefix in install.sh, it should be brew --prefix.

from homebrew-netclient.

mattkasun avatar mattkasun commented on June 5, 2024

is this still an issue with latest release?

from homebrew-netclient.

AlexKMDev avatar AlexKMDev commented on June 5, 2024

There is still an issue while installing netclient:

> brew install netclient
Error: Cask 'netclient' is unreadable: /opt/homebrew/Library/Taps/gravitl/homebrew-netclient/Casks/netclient.rb:6: syntax error, unexpected tIDENTIFIER, expecting end
...5e074d4a53e48b4c1586d8b2007f26f
...^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/opt/homebrew/Library/Taps/gravitl/homebrew-netclient/Casks/netclient.rb:8: syntax error, unexpected tIDENTIFIER, expecting end
...f58e09813839685dc5c43542f3ec97c
...^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

It happens because sha256 hashes aren't escaped in the formula. If I fix it manually on my installation, it works fine now. Thanks!

from homebrew-netclient.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.