Ability = None issue about sc2reader HOT 2 CLOSED

So this is actually a two part issue.

First part, is that replay.events_by_type is kind of misleading now that we've got some type inheritance for events.

Instead of using the following to get all the ability events:

ability_events = replay.events_by_type['AbilityEvent']

you really need to use:

ability_events = [e for e in replay.events if isinstance(e, sc2reader.objects.AbilityEvent)]

which gets the AbilityEvent, UnknownAbilityEvent, LocationAbilityEvent, and TargetAbilityEvents. Its likely that I should change up the processing code and fix/remove that dictionary for now as its not as useful as it once was.

That brings us to the second issue, which is that you were only getting AbilityEvent classed events. There was a bug in the code which didn't pass the ability code into the event constructor for this particular event class.

This second issue is fixed now. I'll figure out what to do with the events_by_type dict later.

from sc2reader.

The root issue with the Ability not being passed through the constructor was resolved months ago.

from sc2reader.