Replay.end_time not set correctly about sc2reader HOT 6 CLOSED

I am assuming this replay was recorded on a Mac? I remember @issackelly having an issue with timestamps on Mac as well.

The code is that way for a reason, checkout the MLG WinterArena replay pack and see for yourself. If I recall my conversation with @issackelly we decided that it might be encoded differently on Mac vs PC. It seems like you've confirmed this suspicion. From a windows recording this seems to work fine.

            self.windows_timestamp = details.file_time-details.utc_adjustment
            self.unix_timestamp = utils.windows_to_unix(self.windows_timestamp)
            self.end_time = datetime.utcfromtimestamp(self.unix_timestamp)
            self.time_zone = details.utc_adjustment/(10**7*60*60)

The following seems to work on Mac replays (but not windows replays):

            self.windows_timestamp = details.utc_adjustment
            self.unix_timestamp = utils.windows_to_unix(self.windows_timestamp)
            self.end_time = datetime.utcfromtimestamp(self.unix_timestamp)
            self.time_zone = (details.utc_adjustment-details.file_time)/(10**7*60*60)

@dsjoerg, can you confirm this (on both platforms?).

I'd like to look for a flag indicating where it was recorded from but if I can't then we can always try one, check for a timestamp < 2010 and then try the other one.

from sc2reader.

Yes, it was recorded on a Mac. I won't be able to confirm anything until Tuesday or Wednesday, I'll check back in then.

from sc2reader.

@dsjoerg, check out the commit above; I think it resolves this issue.

I'll leave it to you for confirmation and closing.

from sc2reader.

Graylin can I leave this to you? I am trying to focus on non-tech stuff that is harder to delegate, like getting the ggtracker bank account set up, get our first deal done and that kind of stuff. If you are confident that this is done you can close it.

from sc2reader.

Yeah, I'll double check this and close it tonight.

from sc2reader.

Alright, I can confirm that this works on the limited Mac files I have available. Perhaps this patch would interest @issackelly and he can re-open if he discovers otherwise.

from sc2reader.