Comments (6)
@Prillan would know.
It seems that the properties have a series of dependencies which must be loaded before you can determine if the property is "active" or not. Given that understanding, it would seem as though it was assumed that all lobby properties would be eventually resolved, one way or the other.
That being said, I see that there is already a hack in place for this exact problem down below it here.
# Use this to avoid an infinite loop
last_success = 0
max = len(left_players)
while len(left_players) > 0 and not (last_success > max+1):
Perhaps a similar patch should be made for now until we better understand the lobby properties.
from sc2reader.
Yes, the hack is there because I was afraid that my implementation of the parsing might cause an infinite loop.
It looks like I forgot it at the place you pointed out...
I'll take a look in a few days when I have time. Thanks for finding it!
from sc2reader.
Ok, so I added the same hack to the general properties as well. I think it's the simplest way to do it and doesn't hurt performance too much.
If it does we'll have to fix it but I don't think it's necessary.
Btw, how do I add the commit to this issue?
from sc2reader.
You can tie commits to issues with commit messages. See the github announcement for details.
Relevant Excerpt:
Commits + Issues
Issues has deep integration with commit messages. Any time you reference an issue number from a commit message, we'll bring in the commits to the discussion view for you.
And of course you can close issues with commit messages.
We support a number of synonyms:
- fixes #xxx
- fixed #xxx
- fix #xxx
- closes #xxx
- close #xxx
- closed #xxx
from sc2reader.
Since you've already made the commit, you can also just reference it in the issue text with the commit id as show below:
Patched with 5eca833798913e85032f197185920611897e6b1b
renders as:
Patched with 5eca833
from sc2reader.
I should probably close this now :)
from sc2reader.
Related Issues (20)
- Merging the different repositories HOT 3
- Build Order Update HOT 3
- "Rejoin" events not used for players list on resumed replays. HOT 2
- Store extension mods on the replay HOT 4
- Encoding Error for certain replays HOT 5
- "TypeError: ord() expected a character, but string of length 0 found" in decoders.py v0.6.5 HOT 3
- UnicodeDecodeError for LotV beta replay HOT 30
- `None` in game events
- Would sc2reader adapt for Heroes? HOT 2
- "2207 bytes left!" on newer replays. HOT 10
- How to build the ability csv file? HOT 5
- New s2protocol HOT 4
- Replay object has no expansion HOT 2
- PLEASE USE ggtracker/sc2reader INSTEAD
- Old replay files HOT 2
- sc2reader broken for new replays HOT 1
- Lazy parsing of SC2Replay file to speed up data science HOT 1
- Export replay as .avi? HOT 4
- struct.error: unpack requires a buffer of 4 bytes
- Meaning of decoded data attributes HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sc2reader.