User MCode Template Questions about core HOT 7 CLOSED

It's after midnight here and I posted my message and shut things down and left the shop. As I was about to turn in for the night I thought "I wonder if I'm blocking the light by accident". So I stuck a delay(2000) in after the rgb_set_state(RGB_WHITE) call and sure enough the light popped on.

I'll improve my state handling in the morning, so you can disregard my request.

Before I forget though, I did have to change something in your code to get it to compile. I changed line 86 in your mcode example from:

return state == Status_Unhandled && user_mcode.validate ? user_mcode.validate(gc_block, parameter_words) : state;

to

return state == Status_Unhandled && user_mcode.validate ? user_mcode.validate(gc_block, deprecated) : state;

It was a guess on my part, please advise if this is a valid change.

Thanks.

from core.

So I stuck a delay(2000) in

If you want your plugin to be generic (usable by all drivers having enough ioports) use
hal.delay_ms(2000, NULL);
instead.

It was a guess on my part, please advise if this is a valid change.

It is valid, I'll fix the template.

from core.

If you want your plugin to be generic (usable by all drivers having enough ioports) use
hal.delay_ms(2000, NULL);
instead.

Yes, I would like it to be usable by all drivers.

I only threw the delay in temporarily as a debug method since I knew it would block, but is that hal call a non-blocking way to generate a delay? That would be very helpful.

from core.

Also, I noticed the "plugins" link in the last sentence of the readme summary on the Templates repo is a broken link.

"The HAL supports a wide range of extension possibilities, this without touching the core grbl codebase. Some examples can be found in the plugins folder."

from core.

I was just looking through the codes at Marlin and this one caught my eye (amusingly, only 1 off from the code I chose). Is it your preference to adopt codes already in use at Marlin, in applicable? This one is a reasonable approximation of the inspection light function I am adding: https://marlinfw.org/docs/gcode/M355.html

from core.

First stop for determining a new M-code is LinuxCNC then Marlin. If no good match is found I try to avoid Marlin codes that has a fair chance of beeing relevant for grblHAL.

from core.

but is that hal call a non-blocking way to generate a delay

Yes, if you supply a callback function. Note that currently only one callback can be active at any time - I plan to change this.

from core.