Make reserved works non-static about php-sql-parser HOT 10 CLOSED

I have included static arrays because of http://code.google.com/p/php-sql-parser/issues/detail?id=59 but it should be possible to change it again. There are access functions, which I use in the code, so there is no direct access to the arrays from inside the parser.

from php-sql-parser.

Ok, I will create a branch with the changes for Shard-Query. I will
compare the speed difference before and after and make sure it isn't too
great.

On Fri, Apr 11, 2014 at 12:31 AM, André Rothe [email protected]:

I have included static arrays because of
http://code.google.com/p/php-sql-parser/issues/detail?id=59 but it should
be possible to change it again. There are access functions, which I use in
the code, so there is no direct access to the arrays from inside the parser.

Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-40177604
.

from php-sql-parser.

I have played around with a Singleton instance of the class... There is no time difference between both versions. I'll check-in the changes.

from php-sql-parser.

Don't use the test cases for the parser at the moment, there are a lot of errors because of the new "hints" property of the FROM clause. All tests of the Creator should work, which include some Parser tests.

from php-sql-parser.

I have my changes almost completed. I have only one issue that I can't seem to track down: When I use a custom function it shows up at 'function' instead of 'custom_function'. You can see an example in the (unfinished) test case I created called customfunctions.php in the test/cases/parser dir.

If you have a moment, do you think you could either fix that or point me in the right direction?

from php-sql-parser.

I'll check this this evening...

from php-sql-parser.

I think, I have fixed the problem.
Can we rename the new function into addCustomFunction (camel case)?

from php-sql-parser.

Hi,

Sure, I will rename it and check out your fix. Thanks!

--Justin

On Sat, Apr 12, 2014 at 1:39 PM, André Rothe [email protected]:

I think, I have fixed the problem.
Can we rename the new function into addCustomFunction (camel case)?

Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-40291193
.

from php-sql-parser.

Looks good. I renamed the function.

from php-sql-parser.

I merged the customfuncs branch into master. I had to make a few changes for the singleton but that was it.

from php-sql-parser.