Giter VIP home page Giter VIP logo

Comments (9)

fivethreeo avatar fivethreeo commented on May 28, 2024 1

Fixed

from loadable-components.

theKashey avatar theKashey commented on May 28, 2024

is it technically different?
This will blow up a little with transpilation/cjs so what about moving responsibility to the end user

const App = extractor.importEntrypiont(await import('test entrypoint'))
//                                     ^ everything under user control

from loadable-components.

fivethreeo avatar fivethreeo commented on May 28, 2024

Yeah that seems better.

from loadable-components.

fivethreeo avatar fivethreeo commented on May 28, 2024
const App = await extractor.importEntrypiont(‘test entrypoint', (entry) => import(entry)))

Maybe?

from loadable-components.

theKashey avatar theKashey commented on May 28, 2024

That will not be statically analyzeable. Not sure if there's a need, it's not analyzable right now, but why you might need such indirection?
Lets apply occam's razor here and cut what we don't have a good reason for.

from loadable-components.

dglozic avatar dglozic commented on May 28, 2024

Also a typo in the example (piont).

from loadable-components.

fivethreeo avatar fivethreeo commented on May 28, 2024
const App = await import(extractor.getEntrypointPath(‘testentrypoint'))

Is better perhaps.

from loadable-components.

fivethreeo avatar fivethreeo commented on May 28, 2024

requireEntrypoint seems to require all script assets up front, so should it import all too?

from loadable-components.

fivethreeo avatar fivethreeo commented on May 28, 2024

In the pull i added you can now do

const extractor = ChunkExtractor({ statsfile: 'loadable-stats.json', entrypoints: ['main'] })
await Promise.all(extractor.getAllScriptAssetsPaths().map(asset=>import(asset)))
const App = await import(extractor.getEntrypointPath('main'))

from loadable-components.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.