Comments (8)
@gregsdennis yes, I could really use that! I already found a solution to my problem but this would allow me to make the code a lot more readable!
from json-everything.
@gregsdennis thanks for your quick response and changes!
from json-everything.
Hey there. I think deserializing in the JsonLogic model might be overkill for your need. Have you considered just parsing into JsonNode
and browsing the JSON data that way?
var rule = JsonNode.Parse(jsonLogicString).AsObject();
if (rule.ContainsKey("and"))
{
foreach (var item in rule["and"].AsArray())
// do stuff with items
}
else if (rule.ContainsKey("or"))
{
// do stuff with orRule.Items
}
You may also want to have a read through #368 as that's the issue where the protected internal
entered the picture.
I could make the properties public, but they're supposed to be immutible, so I'd have to change the property types as well. Since they're accessible via subclasses, it'll be a breaking change.
from json-everything.
I just realized you could do this as well because the .Net team made "decisions" with the JsonNode
API:
var rule = JsonNode.Parse(jsonLogicString);
if (rule["and"] is not null)
{
foreach (var item in rule["and"].AsArray())
// do stuff with items
}
else if (rule.ContainsKey("or"))
{
// do stuff with orRule.Items
}
from json-everything.
I did go that way, but I was hoping that instead of string checking I could check types. That should be more accurate and allow for stricter typed code. But I followed your suggestion and that also works.
What you maybe could do instead of exposing the Item
property is exposing it as an enumerator. That seems to be what the .net team did for JsonDocument as well.
from json-everything.
Thanks for the recommendation. I'll continue to play around with things to see what I can come up with. Maybe extension methods would do?
from json-everything.
I think this could work:
public static IEnumerable<Rule> GetItems(this AndRule rule)
{
return rule.Items.AsReadOnly();
}
Some of them are a bit redundant, but if you don't see the internal properties, I guess you wouldn't notice.
public static Rule GetInput(this AllRule rule)
{
return rule.Input;
}
public static Rule GetRule(this AllRule rule)
{
return rule.Rule;
}
from json-everything.
@birgerj would something like ☝️ work for you? I can push this out soon.
from json-everything.
Related Issues (20)
- that the custom metastructure could not be parsed HOT 4
- How to extend SchemaGenerator for DateTime HOT 7
- JsonSchema.NET DataValidation HOT 10
- Custom `IAttributeHandler` never called HOT 5
- Anchors naming of 2020 still following 2019 rules HOT 5
- Generating a Custom JSON Schema HOT 1
- ArgumentOutOfRangeException thrown when calling JsonSchema's Evaluate methods from multiple threads. HOT 3
- 2020-12 output incorrectly places annotations
- Nullable decimal type removes multipleOf HOT 1
- Boolean applicator keywords must be non-empty HOT 1
- Issues with rendering on docs site HOT 1
- Verified error reporting type HOT 18
- 'Required' is an ambiguous reference between 'System.ComponentModel.DataAnnotations.RequiredAttribute' and 'Json.Schema.Generation.RequiredAttribute'? HOT 22
- Schema exception {"An item with the same key has already been added. Key: Child"} HOT 9
- Possibly wrong return type HOT 10
- Customizing the `format` generated for a field (without attributes) HOT 5
- Json.Schema.KeywordExtensions is not thread safe with custom keywords HOT 1
- Update Nuget package meta-data HOT 6
- Error "unknown context value" Raised After Checking for Existence HOT 2
- Online schema validator: Is successful validation of illegal json just a quirk or intentional HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from json-everything.