Data file: <div class="snippet-clipboard-content notranslate position-relative ove

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Multi regex and matching-rule any reporting failure even though there should be a match. about pykwalify HOT 1 CLOSED

grokzen commented on July 21, 2024

Multi regex and matching-rule any reporting failure even though there should be a match.

from pykwalify.

Comments (1)

comagnaw commented on July 21, 2024

@Grokzen I think I found the issue. Doing some debugging I found that sub_regex_result was not populated with the expected results:

Key: foobar2
Match bool: [True, False] <<<<<< Should be [ True, True ]
Key: foobar1
Match bool: [True, False] <<<<<< Should be [ True, True ]
Key: bar2
Match bool: [False, False] <<<<< Should be [True, False]
 ERROR - validation.invalid
 ERROR -  --- All found errors ---
 ERROR - [u"Key 'bar2' does not match any regex '[1-3]$' or '^foobar'. Path: ''"]

I changed line 473 of core.py from a re.match to re.search:

regex_mappings = [(regex_rule, re.search(regex_rule._map_regex_rule, str(k))) for regex_rule in rule._regex_mappings]
                               ^^^ was re.match

and got the following results.

Key: foobar2
Match bool: [True, True]  <<<<< Expected results
Key: foobar1
Match bool: [True, True]  <<<<< Expected results
Key: bar2
Match bool: [False, True]  <<<<< Expected results
 INFO - validation.valid

This is due to the behavior of match vs search. Match only looks at beginning of string whereas search finds first match anywhere in string.

I can include a fix for this issue and some success unit tests to cover this check in PR 26. This makes sense to me as that PR is already touching that area of the code. Thoughts @Grokzen?

from pykwalify.

Recommend Projects