unique not enforced on mappings about pykwalify HOT 3 CLOSED

Hi.

First some things about the unique operator is that it is intended to be used with sequences/lists/sets mostly. Now when i look in the docs is says that it works for maps but that is not true.

If you try to load your data part into a object with plain yaml inside python, it will because it is a key/value object, overwrite the first k/v with the second k/v and the output from your data will be the following:

{"password": "pass2", "type": "whatever", "user": "user2"}

When it loads the data from your file you have specefied, the same thing will happen and when validation is done, it will not trigger any validation errors. This is in turn a problem inside pyyaml and the loading of provided data. The only real solution you could implement to ensure this is to implement some patch into pyyaml that when it adds a key to a dict, you check if it is already there and raises error from there.

The only other way to implement something that could deal with this type of problem, would be to implement some custom preprocessor/parser that runs on the raw yaml data and tries to find these kinds of problems.

The outcome of this issue as i see it, would be to take a look at the unique tests and possibly update them and maybe block/remove the use of unique inside a map and then update the docs to reflect these changes.

from pykwalify.

Thanks for the info. I agree that updating the docs could benefit users; this defect case in point :)

from pykwalify.

The following commit changes the docs 2af3ea7 to now say that is has no effect on mapping.

from pykwalify.