Giter VIP home page Giter VIP logo

Comments (2)

Grokzen avatar Grokzen commented on July 21, 2024 1

@kesre This fix for this was commited in this commit 8fa18e3 and it fixed the problem. The correct way to deal with this was to move the type checking earlier in the mapping validation so that even if you do not speciefy the mapping keyword and the value type is wrong you should get a error that the value type is bad.

Just to clearify that the keyword allowempty have no impact on this. You really need to have the correct value type before it will be applied or even considered. The correct solution was to give a type error first.

Please open a new issue if you find any other issues with the keyword allowempty

from pykwalify.

kesre avatar kesre commented on July 21, 2024

Not very familiar with the code at all, but at a brief glance,

I'm wondering if this happens because _validate_mapping returns too eagerly in the case of allowempty. (

if rule.mapping is None:
- commit sha here is to make sure I have the right line - not the commit that introduced problems)

I'd expect some sort of check that the value is a mapping at all by the time it gets to _validate_mapping.

from pykwalify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.