Constraint on the length of a sequence? about pykwalify HOT 7 CLOSED

Ye sure that is doable.

It maybe require some bigger refactoring because currently the length/range checks is done inside the scalar validation.

I think that it can be extended to map also.

from pykwalify.

There we go. Implemented in commit: 1847761

Have a look at it.

Keyword 'range' now works for seq, map, str, int. Play around with it some and look at the new test files.

One thing i think i want to do now is to refactor our 'length' because 'range' handles all its cases and more so there is no need to have both currently.

from pykwalify.

I think with this commit something is broken. I'm getting a bunch of failures where I previous had none. It seems the min (and possibly the max) is now doing an exclusive check rather than an inclusive one. So for a schema like:

schema;registers_schema:
    type: seq
    sequence:
        -   type: map
            required: False
            mapping:
                reg:
                    required: True
                    type: str
                value:
                    required: True
                    type: int
                    range:
                        min: 0
                        max: 255

With data like:

- reg: I2S_REG
  value: 0x00

it will fail with the following error (scalar.range.toosmall: 0 > 0) because the value is zero. If I understand things correctly, 'min' as defined above should allow this. As I mentioned, this worked before your latest commit to the develop branch. Can you investigate?

from pykwalify.

Oh yeah, i must have mixed up something in the refactoring of range... It should be fixed in develop branch now.

from pykwalify.

Seems to have fixed my problem after I eliminated the use of the 'length' directive on strings. I'll do further testing later.

from pykwalify.

'lenght' was refactored out in a83008e because 'range' can handle all cases.

And the bug with 'range' was fixed in 5d114df

from pykwalify.

Closing this because i consider the feature to be implemented in the commits mentioned above.

from pykwalify.